1133818 - Fix GCC warnings in widget/windows.

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jacek Caban]

Attachment: fix

With this patch set, mingw build of widget/windows is clean of warnings.

- In WinUtils::LogW the warning was about wrong size passed to memset. However, there is no need for memset at all. Also, wcslen is not the right way to get buffer size after wctmb conversion, so I changed that as well.

- I'm not sure about nsDataObjCollection.h. This fixes hidden virtuals, but maybe in some cases we should change them to real overrides.

- nsWindow::GetPreferredCompositorBackends removal of unused ID3D11Device getter call removes side effect of initializiing D3D11 devices. I'm not sure if it was intended.

try push seems green so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a89b5fc871cc

Comment 1

[Jacek Caban]

Attachment: warnings

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8565489 [details] [diff] [review]
fix

Review of attachment 8565489 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ -6584,5 @@
>      if (prefs.mPreferOpenGL) {
>        aHints.AppendElement(LayersBackend::LAYERS_OPENGL);
>      }
>  
> -    ID3D11Device* device = gfxWindowsPlatform::GetPlatform()->GetD3D11Device();

Flag jrmuizel on this. Looks like this should have been removed, hard to tell.

http://hg.mozilla.org/mozilla-central/rev/6e4cb51583f6

http://hg.mozilla.org/mozilla-central/rev/695772d145a0

Comment 3

[Jacek Caban]

Comment on attachment 8565489 [details] [diff] [review]
fix

Thanks for review.

Comment 4

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0adcaee7f3bb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0adcaee7f3bb