1136177 - Amount by mouse wheel scrolling is wrong

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open long web page (ex. http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/ )
2. Scroll with Mouse Wheel

Actual Results:
Page was scrolled by a page

Expected results:
Page should be scrolled by few lines

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=50752f206a9b&tochange=0adcaee7f3bb

Regressed by: Bug 1133818

Comment 1

[Jacek Caban]

WinMouseScrollHandler.h change probably broke it. I will prepare a fix.

Comment 2

[Jim Mathies [:jimm]]

(In reply to Jacek Caban from comment #1)
> WinMouseScrollHandler.h change probably broke it. I will prepare a fix.

yep, just confirmed, flipping those two vars back to signed fixes the problem.

Comment 5

[Jacek Caban]

Attachment: fix

The fix is attached. I'm sorry for breaking this and thank you for the report.

Comment 7

[Jim Mathies [:jimm]]

Will land this as soon as inbound opens.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bab13c0c9e19

Please try to use more descriptive commit messages in the future (i.e. what the patch is actually doing instead of restating the problem it's solving).

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bab13c0c9e19

Comment 16

[Bartosz Piec]

Will this be included in tomorrow's nightly?

Comment 17

[Lily Kim]

(In reply to Bartosz Piec from comment #16)
Yes.

Comment 18

[Sohan Roy]

Please reopen the bug, I am facing the problem again
https://bugzilla.mozilla.org/show_bug.cgi?id=1136547

Comment 19

[Andrew McCreight [:mccr8]]

(In reply to Sohan Roy from comment #18)
> Please reopen the bug, I am facing the problem again

Nightly hasn't updated yet.

Comment 20

[Lily Kim]

(In reply to Sohan Roy from comment #18)
Nightly updated now and it is fixed. :)

Comment 21

[Jim Mathies [:jimm]]

yep, I can confirm the fix as well.

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

I don't think we need to track this for 39 since it's so early in the cycle and is already fixed and verified. That was fast, thanks!

We certainly had a lot of users notice and report it, so if it happens again, we're likely to hear about it.

Comment 23

[shivamsingha]

i too had this prob, its fixed after another update