1133967 - [Customizer] View CSS and JS files (no editing)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Comment 1

[Doug Sherk (:drs) (inactive)]

Amy, Jacqueline, how do you intend to get to this view? I don't see a reasonable path to it with the current design. Maybe an additional option in the long-press menu to "View Source" if the target node is a `<link>` or has a `src` attribute?

Comment 2

[Justin D'Arcangelo [:justindarc]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)
> Amy, Jacqueline, how do you intend to get to this view? I don't see a
> reasonable path to it with the current design. Maybe an additional option in
> the long-press menu to "View Source" if the target node is a `<link>` or has
> a `src` attribute?

That's what I was thinking. In our current long-press action menu, we can add a "View Source" option for <link> and <script> tags.

Comment 3

[Doug Sherk (:drs) (inactive)]

(In reply to Justin D'Arcangelo [:justindarc] from comment #2)
> That's what I was thinking. In our current long-press action menu, we can
> add a "View Source" option for <link> and <script> tags.

Seems reasonable to me. Though, IMO, our qualifiers for this additional button should be `<link>` and `<script>` elements or the `src` attribute, so that we could also view images (the code path should be nearly identical).

Comment 4

[David Flanagan [:djf]]

Taking this to see if I can move it forward at all.

Comment 5

[David Flanagan [:djf]]

Attachment: link to patch on github

Justin,

Here's the PR for view source. Since I'm new to this framework, I don't think I should land it myself without your review.

I don't have write access to the customizer repo so you'll have to land it anyway.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8566886 [details] [review]
link to patch on github

LGTM. Landed. Also, I'll add you to the repo owners group so you can land in the future. Thanks!

Comment 7

[Jacqueline Savory [:jsavory] UX]

The design for this has been added in the spec, one of the toolbar icons will represent 'View Source'. Let me know if this works.