Add CSSLint support for offset-inline-* and offset-block-*

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.2 S6 (20feb)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed, b2g-master fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
We currently run into errors like: 

Unknown property 'offset-inline-end'.  Declaration dropped. line: 68 column: 19 source: "  offset-inline-end: .8rem;"
Unknown property 'offset-inline-start'.  Declaration dropped. line: 150 column: 21 source: "  offset-inline-start: 0.5rem;"
(Assignee)

Comment 1

3 years ago
I think this might actually be due to having an old copy of b2g running the CSSLinter which does not yet have these new properties. Adding a dependency on 1089710.
Depends on: 1089710
Created attachment 8565886 [details] [review]
[gaia] KevinGrandon:bug_1133971_temp_fix_for_offset_inline_block > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Comment on attachment 8565886 [details] [review]
[gaia] KevinGrandon:bug_1133971_temp_fix_for_offset_inline_block > mozilla-b2g:master

Ricky - could you review this if you have a minute? We need to support these CSS properties for some RTL patches, but unfortunately we don't have the updated b2g build yet - so we need a workaround =(
Attachment #8565886 - Flags: review?(ricky060709)
Comment on attachment 8565886 [details] [review]
[gaia] KevinGrandon:bug_1133971_temp_fix_for_offset_inline_block > mozilla-b2g:master

LGTM. r=me thanks!
Attachment #8565886 - Flags: review?(ricky060709) → review+
Created attachment 8565892 [details] [review]
[gaia] KevinGrandon:bug_1133971_temp_fix_for_offset_inline_block > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
(Github would not let me close/reopen the PR for some reason, so creating a new attachment here.)
(Assignee)

Updated

3 years ago
Depends on: 1134144
(Assignee)

Updated

3 years ago
No longer depends on: 1134144
(Assignee)

Comment 7

3 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/696a316c24416a83bacd3b49c1be65e0124c3dd9

(This may need an uplift if we uplift bug 1129701)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Yeah, thanks for the heads-up there...

v2.2: https://github.com/mozilla-b2g/gaia/commit/ce79d35b92261e7cbfeaefebf87859ebeb0979b4
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Target Milestone: --- → 2.2 S6 (20feb)
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.