Closed Bug 1134001 Opened 5 years ago Closed 5 years ago

[Add-On Manager] Button to add new add-ons by linking to Hacker Marketplace

Categories

(Firefox OS Graveyard :: Gaia, defect, P2)

x86
macOS
defect

Tracking

(b2g-master unaffected)

RESOLVED FIXED
Tracking Status
b2g-master --- unaffected

People

(Reporter: cserran, Assigned: yzen)

References

Details

(Whiteboard: [spark])

Attachments

(2 files)

No description provided.
No longer depends on: 1133999
Assignee: nobody → yzenevich
Attachment #8586298 - Flags: review?(mhenretty)
Comment on attachment 8586301 [details] [review]
[gaia] yzen:bug-1134001 > mozilla-b2g:lightsaber

Lightsaber branch pull request.
Attachment #8586301 - Flags: review?(arthur.chen)
Yura, patch works great! I added a comment on github about two different approaches I think we should take. Let me know what you think.
Comment on attachment 8586301 [details] [review]
[gaia] yzen:bug-1134001 > mozilla-b2g:lightsaber

Thanks, Yura!
Attachment #8586301 - Flags: review?(arthur.chen) → review+
(In reply to Michael Henretty [:mhenretty] from comment #4)
> Yura, patch works great! I added a comment on github about two different
> approaches I think we should take. Let me know what you think.

Addressed PR comments, let me know if it looks better now. Thanks!
Flags: needinfo?(mhenretty)
Comment on attachment 8586298 [details] [review]
fxos/directory pull request

This is excellent work Yura! The only thing I would say is that we are now calling ListController.refreshInstalledList every time we change tabs, which is a little inefficient. But we can fix this later, because I want to merge this now so I can start working off of it.

Thanks!
Flags: needinfo?(mhenretty)
Attachment #8586298 - Flags: review?(mhenretty) → review+
master: https://github.com/fxos/directory/commit/040b7f122d5c30282a401e1e11716f48738fe3a6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Oops, sorry forgot you need to land the Gaia part too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://github.com/mozilla-b2g/gaia/commit/99dbacdc77ce729619968b810d361ca3675c0824
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.