Closed Bug 1133990 Opened 5 years ago Closed 2 years ago

[Meta] Add-On Manager for Firefox OS

Categories

(Firefox OS Graveyard :: Gaia::Settings, enhancement)

ARM
Gonk (Firefox OS)
enhancement
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: cserran, Unassigned)

References

Details

(Keywords: meta, Whiteboard: [spark])

Attachments

(1 file, 4 obsolete files)

Add-On Manager allows users to manage their created and downloaded add-ons.
No longer depends on: spark-p2p-sharing, 1133985, 1133987, 1133989
Blocks: 1133992
No longer blocks: 1133992
Depends on: 1133992
Depends on: 1133993
Depends on: 1133995
Depends on: 1133996
Depends on: 1133997
Depends on: 1133998
Depends on: 1133999
Depends on: 1134001
Attached file App_Manager_IXD_VSD_v1.0.pdf (obsolete) —
UX/VSD spec for App Manager
Attached file App_Manager_IXD_VSD_v1.1.pdf (obsolete) —
Updated list item height/icon size
Attachment #8568832 - Attachment is obsolete: true
Attached file App_Manager_IXD_VSD_v1.1.pdf (obsolete) —
Updated spec to reference web components for list item styling
Attachment #8570123 - Attachment is obsolete: true
Kevin: Bug 1144843, Bug 1144848, Bug 1144849
Flags: needinfo?(kgrandon)
Arthur, EJ - we have some feature work here to do for the settings addon panel that we are looking to have done in the next week or so. Just wondering if either of you would like to help us with this feature work and have free cycles. If not we will try to have someone from our team try to pick this up, thanks!

I think the spec for the "Share" button is a bit incorrect. For the initial work we might want to hide that button.
Flags: needinfo?(kgrandon)
Flags: needinfo?(ejchen)
Flags: needinfo?(arthur.chen)
This looks like something that has already been done in the patch of bug 1131773, do I understand this correctly?
Flags: needinfo?(arthur.chen) → needinfo?(kgrandon)
(In reply to Arthur Chen [:arthurcc] from comment #6)
> This looks like something that has already been done in the patch of bug
> 1131773, do I understand this correctly?

Interesting :) Let's check with Justin here, I didn't see a reference to bug 1131773.
Flags: needinfo?(kgrandon)
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(ejchen)
(In reply to Arthur Chen [:arthurcc] from bug 1144998 comment #5)
> Hi Doug, :djf told me the rename feature in settings app today. I was
> wondering are there any spec or more written details of it?

Amy and Jacqueline are working on a spec for this. We don't have bugs filed yet, but the full list of work that we need done right now is:

* The non-Lightsaber parts of the Add-On Manager landed on master, so that the lightsaber Gaia branch isn't diverging too much from master.
* "Rename" button in add-on views.
* An activity handler that takes the user straight to an add-on view.
* Some visual refinements to be provided by Amy.
Flags: needinfo?(jsavory)
Flags: needinfo?(amlee)
Arthur, will you have time to get to these next week?
Flags: needinfo?(arthur.chen)
I'll review the patch of bug 1131773 first to have a good base for the following work. Hopefully we can start to work on them next week.
Flags: needinfo?(arthur.chen)
Depends on: 1131773
Depends on: 1147092
(In reply to Kevin Grandon :kgrandon from comment #7)
> (In reply to Arthur Chen [:arthurcc] from comment #6)
> > This looks like something that has already been done in the patch of bug
> > 1131773, do I understand this correctly?
> 
> Interesting :) Let's check with Justin here, I didn't see a reference to bug
> 1131773.

Kevin, sorry for the delayed response, I must have overlooked this.

The additional functionality we need added to the Add-on Manager is in Bug 1144849 which should allow add-ons to be able to be renamed when coming from an activity.

However, part of this is that we need to be able to support passing in a parameter to the activity (e.g. the add-on ID) so we can go directly to the add-on detail screen.
Flags: needinfo?(jdarcangelo)
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #8)
> (In reply to Arthur Chen [:arthurcc] from bug 1144998 comment #5)
> > Hi Doug, :djf told me the rename feature in settings app today. I was
> > wondering are there any spec or more written details of it?
> 
> Amy and Jacqueline are working on a spec for this. We don't have bugs filed
> yet, but the full list of work that we need done right now is:
> 
> * The non-Lightsaber parts of the Add-On Manager landed on master, so that
> the lightsaber Gaia branch isn't diverging too much from master.
> * "Rename" button in add-on views.
> * An activity handler that takes the user straight to an add-on view.
> * Some visual refinements to be provided by Amy.

Submitted visual refinements and rename button spec. Clearing NI.
Flags: needinfo?(amlee)
Severity: normal → enhancement
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Summary: [Meta] Add-On Manager → [Meta] Add-On Manager for Firefox OS
Attached file App_Manager_IXD_VSD_v1.1.pdf (obsolete) —
These edits have already been posted to the bug. Updated spec to reflect these edits.

Updated spec:

1. Added rename app/add-on feature
2. Updated header colour
3. Updated element spacing
4. Updated default app icon
Attachment #8570173 - Attachment is obsolete: true
Removing flag as Amy has answered for UX.
Flags: needinfo?(jsavory)
Moved toast to bottom of screen on last page
Attachment #8585498 - Attachment is obsolete: true
Component: Gaia → Gaia::Settings
Whiteboard: [lightsaber] → [spark]
Keywords: meta
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.