1134040 - [RTL][Messages][MMS] - The entered subject text is not RTL aligned.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Joshua Mitchell (Inactive)]

Attachment: 2015-02-17-15-45-35.png

Description:
In English - The text typed in for Subject is aligned to the left and the words MMS appear on the right. In RTL (Arabic) MMS is aligned to the left but the subject line is also aligned to the left next to MMS instead of being aligned to the right side. 

Repro Steps:
1) Update a Flame to 20150217074222
2) Launch message app
3) Compose a new message
4) Enter a Subject

Actual:
Subject text is not properly RTL aligned

Expected:
text will be right-aligned 

Environmental Variables:
Device: Flame 3.0
Build ID: 20150217074222
Gaia: ae02fbdeae77b2002cebe33c61aedeee4b9439fd
Gecko: 4bb425001d8a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 7/7
See attached: screenshot

also reproduces in 2.2

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150217002515
Gaia: ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gecko: 78d823f7be4c
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Julien Wajsberg [:julienw]]

It's aligned on the left when you write LTR text, but on the right when you write RTL text.

And this, both in english and arabic.

I think this is the right behavior.

What do you think Ahmed?

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> It's aligned on the left when you write LTR text, but on the right when you
> write RTL text.
> 
> And this, both in english and arabic.
> 
> I think this is the right behavior.
> 
> What do you think Ahmed?

I just r+'ed Bug 1126388 which removes this in contacts app and makes everything right-aligned.
According to p12 of the spec(1) it is no longer the case :(
Though IMHO comment 1 here makes much more sense..

(1): https://mozilla.app.box.com/s/bcm3s5i2v6js5uk0ws3tsywse8bgncgo

Comment 3

[Delphine Lebédel [:delphine - OOO]]

Triage: talked with Ahmed offline, let's put this in P2

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] autra:bug-1134040 > mozilla-b2g:master

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8567134 [details] [review]
[gaia] autra:bug-1134040 > mozilla-b2g:master

Hi Oleg,

Could you review this for me please?

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8567134 [details] [review]
[gaia] autra:bug-1134040 > mozilla-b2g:master

r=me in the commit message, but make sure Treeherder is happy before landing (left comment about failing unit test at GitHub).

Thanks!

Comment 7

[Augustin Trancart [:autra]]

Ooops forgot to remove that as well. NI me to land when treeherder is all green.

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b594680ab18cc0e457edb66254c75548c7fdc569

Comment 9

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on latest b2g inbound build. Now even when entering English as subject, it's right aligned. SMS body entering field is still left aligned when entering English though.

Device: Flame 3.0 Master (full flash 319MB mem)
BuildID: 20150224155210
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: af1e21dc0e01
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Not adding verifyme for 2.2 since there's not a decision on uplifting to 2.2.