1134148 - Decide what to do when a tab queue request is received without a URL

Status: RESOLVED DUPLICATE of bug 1155994

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Decide what we do if we receive a request for the tab queue which doesn't contain a url.  

I think popping up a toast is the wrong way to go as it can easily get confused with the toast popup for a normal tab queue insertion; also there's nothing the user can do anything about an app which is sending malformed intents. 

During testing I noticed that, before I had a invalid URL check, the toast created by TabQueueService was being shown without any action on my behalf - it's important that we don't spam the user with invalid messages.  I can't recreate this issue currently but did see it multiple times.

Comment 1

[Richard Newman [:rnewman]]

If there's still some text, could be used to start a search. But this seems like a bug in an intent handler manifest definition somewhere…

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

If we don't receive a URL, why not just drop the request? I assume this should not happen often.

Comment 3

[Martyn Haigh (:mhaigh)]

I'm up for just dropping it - it feels like an edge case that we receive an intent without any data but we can put some telemetry in there to validate that assumption if needed.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Martyn Haigh (:mhaigh) from comment #3)
> I'm up for just dropping it - it feels like an edge case that we receive an
> intent without any data but we can put some telemetry in there to validate
> that assumption if needed.

Agreed. If this happens with TabQueue, it has to be happening now, without TabQueue. In those cases we just open Firefox and try not to crash (see SafeIntent code).

Comment 5

[Richard Newman [:rnewman]]

If you're receiving a null intent, that's not unexpected with Android services. E.g., Bug 1030740.

If you're receiving an intent with no URL, then that's something else.

Comment 6

[Martyn Haigh (:mhaigh)]

Fair point - I can't reproduce atm, so unsure which it is.

Comment 7

[Martyn Haigh (:mhaigh)]

Closing as this has been fixed by bug 1155994