1134229 - Highest rated playlist doesn't work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

Discovered when writing test for bug 1122084. 

Manual STR:

- Put some music on your FxOS device
- Make sure they have no rating.
- Select a song (not at the top of any list) and apply a rating of 5.
- Select another song and apply a rating of 4.
- Go to playlist, tap "Highest rated"

Expected
- The two song mentionned above are at the top of the list in their rating order

Observed
- Nope. they are not.

This is master.

Comment 1

[Hubert Figuiere [:hub]]

No-Jun, can you tell us if that works on 2.2?

Thanks,

Comment 2

[No-Jun Park [:njpark]]

Yes it does repro in latest 2.2, also, those two songs were actually at the bottom of the list.

Gaia-Rev        da509caa7395d3d090ce973e8de082b4680a590d
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/96da179a7d3a
Build-ID        20150218002515
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150218.041956
FW-Date         Wed Feb 18 04:20:07 EST 2015
Bootloader      L1TC000118D0

Comment 3

[Hubert Figuiere [:hub]]

*sigh*

Shall we fix this in 2.2? I'll definitely will in 3.0 as I have a test for it.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1134229-playlist-order > mozilla-b2g:master

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8566165 [details] [review]
[gaia] hfiguiere:bug1134229-playlist-order > mozilla-b2g:master

This is a bug my test found.

Comment 6

[Hema Koka [:hema]]

Hub: Go ahead with fix and ask for approval (since it is a broken feature though happening in previous releases too)

Comment 7

[Hema Koka [:hema]]

Hub: Good find with the tests :)

Comment 8

[No-Jun Park [:njpark]]

Just checked that this feature was working in 2.0 and 2.1.  I just remembered that we do have moztrap test case to cover the rating scenario, so it should've been caught for previous releases.  Adding regression flag.

Comment 9

[Hubert Figuiere [:hub]]

Moztrap is https://moztrap.mozilla.org/manage/case/3674/

That's what I'm automating in bug 1122084.

Comment 11

[Dominic Kuo [:dkuo]]

Comment on attachment 8566165 [details] [review]
[gaia] hfiguiere:bug1134229-playlist-order > mozilla-b2g:master

Hub, thanks for catching and fixing this, the patch looks good to me, just a minor issue and please read it on github, thanks!

Comment 12

[Hubert Figuiere [:hub]]

I was told it did affect 2.1 too.

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1ff734dba9812f34782b8dabb1ce3b2bdb7ca0e3

Comment 14

[Hubert Figuiere [:hub]]

Comment on attachment 8566165 [details] [review]
[gaia] hfiguiere:bug1134229-playlist-order > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Broken feature that did work before
[User impact] if declined: Feature won't work in 2.2 albeit in earlier version it does
[Testing completed]: I have a test in a different bug. Did use it to test (discover) this.
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5a10809279c00e8b0105c43d8780438a8356c1ee

Comment 16

[bhavana bajaj [:bajaj]]

Requesting QA verification on 2.2/3.0.

Comment 17

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Flame v2.2&3.0.
See attachment: verified_v2.2.mp4
Reproduce rate: 0/5

STR:
1.Copy some music into device.
2.Make sure they have no rating.
3.Select a song (not at the top of any list) and apply a rating of 5.
4.Select another song and apply a rating of 4.
5.Go to playlist, tap "Highest rated"
**The two song mentionned above are at the top of the list in their rating order.

Flame 2.2 build:
Build ID               20150310002536
Gaia Revision          166491b92278dc9e648f8d49ab02d9ca00d74421
Gaia Date              2015-03-06 18:26:27
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1cda026f8996
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150310.042346
Firmware Date          Tue Mar 10 04:23:56 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150310160234
Gaia Revision          943c8b4039f59b08ba100390e164a076a20c892e
Gaia Date              2015-03-10 20:35:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a9aff724afc7
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150310.192051
Firmware Date          Tue Mar 10 19:21:00 EDT 2015
Bootloader             L1TC000118D0

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.mp4