1134334 - Intermittent run-by-dir test_0900_deprecatedUpdateFormat_minor.xul | Checking currentPage.pageid equals checking in pageshow - got downloading, expected checking

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

From a try run of mochitest-other run-by-dir
https://tbpl.mozilla.org/php/getParsedLog.php?id=58747858&tree=Try&full=1

16:17:09     INFO -  3256 INFO TEST-OK | toolkit/mozapps/update/tests/chrome/test_0900_deprecatedUpdateFormat_minor.xul | took 4468ms
16:17:10     INFO -  [10084] WARNING: GetDefaultCharsetForLocale: need to add multi locale support: file /builds/slave/try-lx-d-000000000000000000000/build/src/intl/locale/unix/nsUNIXCharset.cpp, line 101
16:17:10     INFO -  ++DOMWINDOW == 185 (0x9e82e190) [pid = 10084] [serial = 678] [outer = 0x9cb22460]
16:17:10     INFO -  [10084] WARNING: 1 sort operation has occurred for the SQL statement '0x989aa900'.  See https://developer.mozilla.org/En/Storage/Warnings details.: file /builds/slave/try-lx-d-000000000000000000000/build/src/storage/src/mozStoragePrivateHelpers.cpp, line 114
16:17:10     INFO -  ++DOMWINDOW == 186 (0x9e82e380) [pid = 10084] [serial = 679] [outer = 0x9cb22840]
16:17:10     INFO -  JavaScript error: , line 0: uncaught exception: 2147500037
16:17:11     INFO -  --DOCSHELL 0x9d347c00 == 21 [pid = 10084] [id = 189]
16:17:11     INFO -  --DOCSHELL 0x9d68f800 == 20 [pid = 10084] [id = 190]
16:17:11     INFO -  --DOCSHELL 0x98f61400 == 19 [pid = 10084] [id = 186]
16:17:11     INFO -  --DOCSHELL 0x98f67400 == 18 [pid = 10084] [id = 187]
16:17:11     INFO -  --DOCSHELL 0x98179000 == 17 [pid = 10084] [id = 180]
16:17:11     INFO -  --DOCSHELL 0x9c878c00 == 16 [pid = 10084] [id = 181]
16:17:11     INFO -  --DOCSHELL 0x9dfddc00 == 15 [pid = 10084] [id = 183]
16:17:11     INFO -  --DOCSHELL 0x9e23d000 == 14 [pid = 10084] [id = 184]
16:17:11     INFO -  --DOMWINDOW == 185 (0x98e89ac0) [pid = 10084] [serial = 590] [outer = (nil)] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
16:17:11     INFO -  --DOMWINDOW == 184 (0x98e89cb0) [pid = 10084] [serial = 591] [outer = (nil)] [url = chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/test_0123_check_allowNonBuiltinCert_noCertAttrsCheck.xul]
16:17:11     INFO -  --DOMWINDOW == 183 (0x98e88190) [pid = 10084] [serial = 600] [outer = (nil)] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
16:17:12     INFO -  ++DOMWINDOW == 184 (0x98e88190) [pid = 10084] [serial = 680] [outer = 0x9cb1d6e0]
16:17:12     INFO -  3257 INFO TEST-START | toolkit/mozapps/update/tests/chrome/test_0901_deprecatedUpdateFormat_major.xul
16:17:12     INFO -  ++DOMWINDOW == 185 (0x98e898d0) [pid = 10084] [serial = 681] [outer = 0x9cb1d6e0]
16:17:12     INFO -  16:17:12:227 | TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js | [runTestDefault : 1258] entering
16:17:12     INFO -  3258 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_0901_deprecatedUpdateFormat_major.xul | Found an existing Update Window from the current or a previous test... attempting to close it. - expected PASS

Comment 1

[Robert Strong (they/them - no direct email)]

Actually, the previous test is the problem
http://example.com/chrome/toolkit/mozapps/update/tests/chrome/update.sjs?oldFormat=1&type=minor&appVersion=38.0a1&platformVersion=38.0a1
16:17:40     INFO -  ++DOCSHELL 0x9aec9800 == 13 [pid = 10099] [id = 194]
16:17:40     INFO -  ++DOMWINDOW == 122 (0x9ca48800) [pid = 10099] [serial = 662] [outer = (nil)]
16:17:40     INFO -  ++DOMWINDOW == 123 (0x9ca4ac00) [pid = 10099] [serial = 663] [outer = 0x9ca48800]
16:17:41     INFO -  *** AUS:SVC readStringFromFile - file doesn't exist: /builds/slave/test/build/application/firefox/updates/0/update.status
16:17:41     INFO -  *** AUS:SVC readStatusFile - status: null, path: /builds/slave/test/build/application/firefox/updates/0/update.status
16:17:41     INFO -  *** AUS:SVC Checker:getUpdateURL - update URL: http://example.com/chrome/toolkit/mozapps/update/tests/chrome/update.sjs?oldFormat=1&type=minor&appVersion=38.0a1&platformVersion=38.0a1
16:17:41     INFO -  *** AUS:SVC Checker: checkForUpdates, force: false
16:17:41     INFO -  *** AUS:SVC Checker:getUpdateURL - update URL: http://example.com/chrome/toolkit/mozapps/update/tests/chrome/update.sjs?oldFormat=1&type=minor&appVersion=38.0a1&platformVersion=38.0a1
16:17:41     INFO -  *** AUS:SVC recordInHealthReport - updateCheckStart - 0
16:17:41     INFO -  *** AUS:SVC Checker:checkForUpdates - sending request to: http://example.com/chrome/toolkit/mozapps/update/tests/chrome/update.sjs?oldFormat=1&type=minor&appVersion=38.0a1&platformVersion=38.0a1
16:17:41     INFO -  JavaScript strict warning: , line 0: TypeError: setting a property that has only a getter
16:17:41     INFO -  ++DOCSHELL 0x9815d400 == 14 [pid = 10099] [id = 195]
16:17:41     INFO -  ++DOMWINDOW == 124 (0x9ac9aea0) [pid = 10099] [serial = 664] [outer = (nil)]
16:17:41     INFO -  ++DOCSHELL 0x9ca4e000 == 15 [pid = 10099] [id = 196]
16:17:41     INFO -  ++DOMWINDOW == 125 (0x9ac9ba40) [pid = 10099] [serial = 665] [outer = (nil)]
16:17:41     INFO -  ++DOMWINDOW == 126 (0x9ac9bc30) [pid = 10099] [serial = 666] [outer = 0x9ac9ba40]
16:17:41     INFO -  ++DOMWINDOW == 127 (0x9ac9be20) [pid = 10099] [serial = 667] [outer = 0x9ac9aea0]
16:17:41     INFO -  *** AUS:SVC Checker:onLoad - request completed downloading document
16:17:41     INFO -  *** AUS:SVC Checker:getUpdateURL - update URL: http://example.com/chrome/toolkit/mozapps/update/tests/chrome/update.sjs?oldFormat=1&type=minor&appVersion=38.0a1&platformVersion=38.0a1
16:17:41     INFO -  *** AUS:SVC Checker:onLoad - number of updates available: 1
16:17:41     INFO -  *** AUS:SVC recordInHealthReport - updateCheckSuccess - 0
16:17:41     INFO -  *** AUS:SVC UpdateService:_selectAndInstallUpdate - add-on compatibility check not performed due to the update version being the same as the current application version, just download the update
16:17:41     INFO -  *** AUS:SVC Creating Downloader
16:17:41     INFO -  *** AUS:SVC UpdateService:_downloadUpdate
16:17:41     INFO -  *** AUS:SVC readStringFromFile - file doesn't exist: /builds/slave/test/build/application/firefox/updates/0/update.status
16:17:41     INFO -  *** AUS:SVC readStatusFile - status: null, path: /builds/slave/test/build/application/firefox/updates/0/update.status
16:17:41     INFO -  *** AUS:SVC recordInHealthReport - partialUpdateStart - 0
16:17:41     INFO -  *** AUS:SVC Downloader:downloadUpdate - downloading from http://example.com/chrome/toolkit/mozapps/update/tests/data/simple.mar to /builds/slave/test/build/application/firefox/updates/0/update.mar
16:17:41     INFO -  ++DOMWINDOW == 128 (0x9ac99380) [pid = 10099] [serial = 668] [outer = 0x9ac9aea0]
16:17:41     INFO -  ++DOMWINDOW == 129 (0x9ac9a8d0) [pid = 10099] [serial = 669] [outer = 0x9ac9ba40]
16:17:41     INFO -  *** AUS:UI gUpdates:onLoad - setting current page to startpage downloading
16:17:41     INFO -  16:17:41:722 | TEST-INFO | chrome://mochitests/content/chrome/toolkit/mozapps/update/tests/chrome/utils.js | [defaultCallback : 1418] entering - TESTS[0], pageid: checking, aEvent.originalTarget.nodeName: wizardpage
16:17:41     INFO -  3256 INFO TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/chrome/test_0900_deprecatedUpdateFormat_minor.xul | Checking currentPage.pageid equals checking in pageshow - got downloading, expected checking

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch - just use the integer

Comment 4

[Stephen A Pohl [:spohl]]

Comment on attachment 8566220 [details] [diff] [review]
patch - just use the integer

Review of attachment 8566220 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/chrome/utils.js
@@ +882,5 @@
>  
> +  // Prevent nsIUpdateTimerManager from notifying nsIApplicationUpdateService
> +  // to check for updates by setting the last update time to the maximum value
> +  // allowed for an integer preference.
> +  Services.prefs.setIntPref(PREF_APP_UPDATE_LASTUPDATETIME,  2147483647);

nit: extra space before integer

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch with nit picked

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/30d3e9381a50

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: new patch

I forgot that there is code that will reset the lastUpdateTime to a reasonable value when it is too far into the future or too far into the past.

Comment 8

[Robert Strong (they/them - no direct email)]

Backed out
https://hg.mozilla.org/integration/mozilla-inbound/rev/d48bfd6bc6a1

Comment 9

[Robert Strong (they/them - no direct email)]

Try run that showed this bug
https://tbpl.mozilla.org/?rev=2052fea1dc91&tree=Try

Try run to see if things are better with this and a previously landed patch
https://tbpl.mozilla.org/?tree=Try&rev=099bf97aafae

Comment 10

[Robert Strong (they/them - no direct email)]

Joel, just an fyi that this patch appears to fix the remaining issues with app update tests and run-by-dir.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

:rstrong, thanks, I will wait for this to land, and thanks for jumping on this and getting it fixed!

Comment 12

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/eff950c4b958

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eff950c4b958