Closed Bug 1134414 Opened 9 years ago Closed 9 years ago

FF37 What's New Page Production

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bensternthal, Assigned: agibson)

References

Details

(Whiteboard: [kb=1678336] )

Attachments

(2 files)

GitHub pull request
44 bytes, text/x-github-pull-request
Details | Review
Screen Shot 2015-03-25 at 2.36.05 PM.png
677.59 KB, image/png
Details 
This bug tracks the delivery of the FF37 What's New Page.

Includes:
- adding page to bedrock
- css & html production
Looks like the PSD is ready so I can at least start putting a basic template together: https://bugzilla.mozilla.org/show_bug.cgi?id=1134049#c3
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Whiteboard: [kb=1688642]
Ok this is now up on a demo server:

https://www-demo3.allizom.org/en-US/firefox/37.0/whatsnew/

To the best of my knowledge all strings from Bug 1134401 are considered final, and should be in the template above for l10n.

Please note: this is just a basic template at the minute. The SMS form does not yet have plumbing, the email form just points to our regular newsletter still. The geo-location work has also yet to be implemented.
Hi Paul, working branch for the above page is here:

https://github.com/mozilla/bedrock/tree/bug-1134414-ff37-whatsnew-page

Would you please be able to help me hook up the backend for the SMS form in the view, like we discussed?

Please just ping me if you have any questions. Aside from changing any strings, also feel free to change anything should you need.

Many thanks!
Flags: needinfo?(pmac)
Whiteboard: [kb=1688642] → [kb=1678336]
(In reply to Alex Gibson [:agibson] from comment #3)
> Would you please be able to help me hook up the backend for the SMS form in
> the view, like we discussed?

On it.

I do have one question so far. Should this SMS form have the optin check box and disclaimers from https://www.mozilla.org/en-US/firefox/sms/ ? They're visible once you focus the field.
Flags: needinfo?(pmac)
Would it also be useful to include the string "SMS service available in the U.S. only" just to be on the safe side?
AFAIK we are using the same text that was used in the snippet https://snippets.mozilla.com/show/5115/

The only change I am aware of is that we will likely need. "Learn More" with a link at the end of the disclaimer.

Just to be absolutely sure, I will add a note to clarify this in the legal bug.
More than just the text though is an optin checkbox for our list of mobile subscribers. Not sure how the Email Engagers feel about that, but seemed odd not to have it here.
I just pushed the backend changes to the branch:

https://github.com/mozilla/bedrock/commit/1621994e5150c0e9620da8d189ded3ab6d835fd9

The look and animation for the success message and errors still needs work and I was hoping you might help with that Alex. I've got error messages and success message basic transitions working though. I've also not yet hooked up the "send another" link.
(In reply to Paul McLanahan [:pmac] from comment #8)
> I just pushed the backend changes to the branch:
> 
> https://github.com/mozilla/bedrock/commit/
> 1621994e5150c0e9620da8d189ded3ab6d835fd9
> 
> The look and animation for the success message and errors still needs work
> and I was hoping you might help with that Alex. I've got error messages and
> success message basic transitions working though. I've also not yet hooked
> up the "send another" link.

Awesome thanks, Paul!

I'll pick up these other bits tomorrow. Thanks for the helping hand!
Ben, can you please let me know the correct newsletter ID I should use for the email form on this page? Many thanks
Flags: needinfo?(bniolet)
It's live on basket stage: 

slug: 

download-firefox-android
Flags: needinfo?(bniolet)
Thanks, Ben

I've included the above slug as the newsletter ID and pushed to demo3:

https://www-demo3.allizom.org/en-US/firefox/37.0/whatsnew/

The email newsletter is not submitting successfully, which I'm guessing is because demo3 is not pointing to basket stage. Also, the list of available languages appears empty when using this ID. I'm not entirely clear why this is.

Can either yourself or pmac advise here?
Flags: needinfo?(pmac)
Flags: needinfo?(bniolet)
If I understand how basket works, the language field is controlled by the languages listed in Basket. So the fact that the drop down is blanks supports the theory that the form is not pointing to Basket Stage, which is where it would retrieve the correct languages.
Flags: needinfo?(bniolet)
Ah, yes if I set BASKET_URL = 'http://basket.allizom.org' in my local.py then I see the list of appropriate languages ok - so I think we do just need to point the demo server to basket stage.

Incidentally if I try submitting the email form locally then everything seems to be going through fine - but I do not seem to be receiving any emails yet.
And you shouldn't see any yet. Basket Stage is linked to our live ExactTarget instance, but I haven't activated any emails for it yet. I'll get them loaded this week (still in coding and QA).
Flags: needinfo?(pmac)
We should just add the newsletter to basket dev. It's what basket dev is for. It's a little broken at the moment, but it should work well enough for what you want to test. Can you do that Ben?
Sure. I skipped it this time because of its broken state, but adding now. Should be live in the next 10 minutes.
Done.
Thanks Ben. We do need to fix it. Is there a way you can reset the password for the account on the sandbox server? We should see what we can do. But for this the connection to ET isn't as important as the newsletter info coming from basket for bedrock to display the right thing.
It's been changed. 

I'll ping you new pw in IRC.
Attached file GitHub pull request — 
I've opened a pull request for the bedrock /whatsnew page but marked it as "do not merge" for now, so we can at least start code review.
Seems the email form is no longer working again on basket-dev.allizom.org, fwiw.
pmac? ^

is this a result of our password change?
Flags: needinfo?(pmac)
Seems it is the same error for all bedrock email newsletter forms pointing to basket dev, so the password change could well be linked.
I wasn't aware that basket-dev had been fixed? Did the original password get set on the testing account Ben?
Flags: needinfo?(pmac)
I set the password yesterday on sandbox to the same as on prod. 

Alex, did the form ever work on basket-dev?
(In reply to Ben Niolet from comment #26)
> I set the password yesterday on sandbox to the same as on prod. 
> 
> Alex, did the form ever work on basket-dev?

For a short-while yesterday, yes it seemed to be working.
Hi Ben,

I'm guessing basket-dev is still not working? :( 

When do you think emails will be enabled and testable on stage? Ideally this page needs to be reviewed and merged today. I can instruct whoever does the review to use basket.allizom.org instead of basket-dev, but it would be great to have both forms being workable so we can verify everything looks good. Do you think this is do-able for today?

Many thanks,

Alex
Flags: needinfo?(bniolet)
Hi Alex. I have an English version of the email ready to code and load and I should be able to get that going in earnest today. 

I think given our time crunch it makes sense to go ahead and move up to basket-staging: basket.allizom.org. Basket dev has other issues going on that pmac and I will have to sort out soon. This is my P1 today. I'll flag here when all of the below is finished:: 

1) create newsletter slug on basket staging. 
2) activate triggered email for EN in ExactTarget live
Flags: needinfo?(bniolet)
(In reply to Ben Niolet from comment #29)
> Hi Alex. I have an English version of the email ready to code and load and I
> should be able to get that going in earnest today. 
> 
> I think given our time crunch it makes sense to go ahead and move up to
> basket-staging: basket.allizom.org. Basket dev has other issues going on
> that pmac and I will have to sort out soon. This is my P1 today. I'll flag
> here when all of the below is finished:: 
> 
> 1) create newsletter slug on basket staging. 
> 2) activate triggered email for EN in ExactTarget live

Hi,

Can you confirm that you will use your own resources to get that email translated into the locales we target? Thanks
Sure thing, Pascal. The email has already been translated by the email L10n teams. I'll be sending them proofs for review and correction later today. Thanks!
Okay. Sorry for the delay. It's been that kind of day. 

EN, HTML Trigger created in ExactTarget. Using a curl to basket.allizom.org, I was able to get the email to fire. A subsequent query in ExactTarget confirmed that the correct email address was added to the correct Data Extensions. 

I have a couple tweaks to make to the HTML, but it's live and it works. 

Next steps for me (this afternoon, early tomorrow: code and load l10n versions. Load txt only versions). 

Create correct triggers.
Flags: needinfo?(agibson)
(In reply to Ben Niolet from comment #32)
> Okay. Sorry for the delay. It's been that kind of day. 
> 
> EN, HTML Trigger created in ExactTarget. Using a curl to basket.allizom.org,
> I was able to get the email to fire. A subsequent query in ExactTarget
> confirmed that the correct email address was added to the correct Data
> Extensions. 
> 
> I have a couple tweaks to make to the HTML, but it's live and it works. 
> 
> Next steps for me (this afternoon, early tomorrow: code and load l10n
> versions. Load txt only versions). 
> 
> Create correct triggers.

Many thanks, Ben. 

Testing locally against basket.allizom.org, I can confirm that I receive the email as expected once the form is submitted :)
Flags: needinfo?(agibson)
Basket Stage is live. All emails and triggers are live. I'll do thorough testing tomorrow.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Adding a testing note, testing from vpn in germany the sms form correctly does not appear.
Verified emails on multiple locales/formats- I'll let Ben verify that ET was correct in his testing.
Verified. All testing addresses are in the Master_Subscribers data extension and have the correct flags assigned.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: