1134484 - Implement v1 color palette

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Find and replace all instances of the colors used!

This should probably be step 1 in completing meta bug 1127517.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1134484/mcomella

/r/4327 - Bug 1134484 - Add Fennec color palette to colors.xml. r=liuche
/r/4329 - Bug 1134484 - Replace all uses of @color/fennec_ui_orange. r=liuche

Pull down these commits:

hg pull review -r 42d07061b917fea4d52cbf29ae734ae7bd3591f8

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Let's review and land this in pieces.

The commits in comment 1 are to demonstrate my workflow and make sure I'm not missing anything. I recommend reading the extended commit messages for my specific methodology. I intend to make a commit for each color I replace.

Comment 3

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4327/#review3585

Comment 4

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4329/#review3587

I noticed that there's an instance of #FF9500 that you missed:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/search_colors.xml#9

Does Search activity use resources in a different way causing you not to update it?

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

https://reviewboard.mozilla.org/r/4325/#review3591

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/4329/#review3593

Assumed they did but apparently they don't - all better.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/e124c25545d2
remote:   https://hg.mozilla.org/integration/fx-team/rev/c6a8c48e0126

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

https://reviewboard.mozilla.org/r/4325/#review3619

Ship It!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e124c25545d2
https://hg.mozilla.org/mozilla-central/rev/c6a8c48e0126

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

/r/4327 - Bug 1134484 - Replace all uses of @color/action_orange with resource name. r=liuche
/r/4329 - Bug 1134484 - Replace all uses of @color/action_orange_pressed. r=liuche
/r/4481 - Bug 1134484 - Replace all uses of @color/link_blue. r=liuche
/r/4483 - Bug 1134484 - Replace uses of @color/placeholder_active_grey. r=liuche
/r/4485 - Bug 1134484 - Replace uses of @color/placeholder_grey. r=liuche

Pull down these commits:

hg pull review -r 69a2712f9fdaab5c5d57e9f1e99d8c0420cc30a7

Comment 11

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4483/#review3695

Ship It!

Comment 12

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4485/#review3697

Ship It!

::: mobile/android/base/resources/values/colors.xml
(Diff revision 1)
>    <color name="text_color_tertiary">#9198A1</color>

One thing that is confusing is that there are now references to "inverse" or "tertiary," which have no point of reference now. This happens with the flavors of text_color_primary.

Perhaps there should be a comment referring to what uses "placeholder_grey" should be used (secondary text, etc).

Thoughts: Add a comment about the colors that are primary and secondary. Alternatively (or maybe in addition), file a bug to fix the inverse, tertiary, ect colors. This could be tricky because the "inverse" of text_color_primary is probably not the "inverse" of placeholder_grey" - in fact, inverse probably has no meaning outside the context of text.

We could also consider keeping text_color_primary/secondary, and just referring to placeholder grey.

Comment 13

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4481/#review3715

Ship It!

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

https://reviewboard.mozilla.org/r/4325/#review3733

Ship It!

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/4f2d7e4cea0a
remote:   https://hg.mozilla.org/integration/fx-team/rev/d361972bd931
remote:   https://hg.mozilla.org/integration/fx-team/rev/81e0dc45d8ef
remote:   https://hg.mozilla.org/integration/fx-team/rev/44cc8ee1aae6
remote:   https://hg.mozilla.org/integration/fx-team/rev/0e58b1e0fe8b

Comment 16

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We discussed via irc and irl:

(In reply to Chenxia Liu [:liuche] from comment #12)
> One thing that is confusing is that there are now references to "inverse" or
> "tertiary," which have no point of reference now. This happens with the
> flavors of text_color_primary.

The intent is to remove these eventually because we want to have a common set of names with which to talk to UX.

> Perhaps there should be a comment referring to what uses "placeholder_grey"
> should be used (secondary text, etc).

The names should (hopefully) be descriptive enough - we're in the process looking into renaming "placeholder grey" and "placeholder active grey" to something like "input placeholder grey" and "input active grey".

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f2d7e4cea0a
https://hg.mozilla.org/mozilla-central/rev/d361972bd931
https://hg.mozilla.org/mozilla-central/rev/81e0dc45d8ef
https://hg.mozilla.org/mozilla-central/rev/44cc8ee1aae6
https://hg.mozilla.org/mozilla-central/rev/0e58b1e0fe8b

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

/r/4327 - Bug 1134484 - Replaces uses of @color/private_toolbar_grey. r=liuche
/r/4329 - Bug 1134484 - Replace uses of @color/text_and_tabs_tray_grey. r=liuche
/r/4481 - Bug 1134484 - Replace uses of @color/tabs_tray_grey_pressed. r=liuche
/r/4483 - Bug 1134484 - Replace uses of @color/toolbar_icon_grey. r=liuche
/r/4485 - Bug 1134484 - Replace uses of @color/tabs_tray_icon_grey. r=liuche
/r/6425 - Bug 1134484 - Replace uses of @color/disabled_grey. r=liuche
/r/6427 - Bug 1134484 - Replace uses of @color/toolbar_grey_pressed. r=liuche
/r/6429 - Bug 1134484 - Replace uses of @color/toolbar_menu_dark_grey. r=liuche
/r/6431 - Bug 1134484 - Replace uses of @color/toolbar_grey. r=liuche
/r/6433 - Bug 1134484 - Replace uses of @color/about_page_header_grey. r=liuche

Pull down these commits:

hg pull -r df66100448cd59cbf83fd4209baabe2c73cc104b https://reviewboard-hg.mozilla.org/gecko/

Comment 19

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4327/#review6313

Ship It!

Comment 20

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4329/#review6329

::: mobile/android/base/resources/layout-large-land-v11/tabs_panel_sidebar.xml:16
(Diff revision 3)
> -              android:background="@color/background_tabs">
> +              android:background="@color/text_and_tabs_tray_grey">

I guess this file no longer exists. Sorry for the bitrot :(

Comment 21

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4329/#review6331

Ship It!

Comment 22

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4481/#review6333

Ship It!

Comment 23

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4483/#review6335

Ship It!

Comment 24

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/4485/#review6337

Ship It!

Comment 25

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6425/#review6339

Ship It!

Comment 26

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6427/#review6341

Ship It!

Comment 27

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6429/#review6343

Ship It!

Comment 28

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6431/#review6345

Ship It!

Comment 29

[Chenxia Liu [:liuche]]

https://reviewboard.mozilla.org/r/6433/#review6347

Ship It!

::: mobile/android/base/resources/values/colors.xml:29
(Diff revision 1)
>  

Might as well remove this newline - it's extraneous and looks confusing.

::: mobile/android/base/resources/layout-large-v11/new_tablet_tabs_counter.xml:13
(Diff revision 1)
> -                                         android:textColor="@color/text_color_primary_inverse"
> +                                         android:textColor="@color/about_page_header_grey"

Looks like this has been switched to @color/toolbar_grey in the current tree. Hm, by something that *I* reviewed. Okay.

Comment 30

[Chenxia Liu [:liuche]]

Comment on attachment 8569517 [details]
MozReview Request: bz://1134484/mcomella

https://reviewboard.mozilla.org/r/4325/#review6349

Ship It!

Comment 31

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/f8b7157f33fe
https://hg.mozilla.org/integration/fx-team/rev/eb326c47ab2d
https://hg.mozilla.org/integration/fx-team/rev/4b88fac7a66d
https://hg.mozilla.org/integration/fx-team/rev/d713b06ac1f0
https://hg.mozilla.org/integration/fx-team/rev/81b06d750659
https://hg.mozilla.org/integration/fx-team/rev/24f82e8e71bd
https://hg.mozilla.org/integration/fx-team/rev/d26259d64016
https://hg.mozilla.org/integration/fx-team/rev/798fa0bcb00f
https://hg.mozilla.org/integration/fx-team/rev/40acd7f334ad
https://hg.mozilla.org/integration/fx-team/rev/6e18d1c774b8

Comment 32

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/614a4bdd3639

Comment 33

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8b7157f33fe
https://hg.mozilla.org/mozilla-central/rev/eb326c47ab2d
https://hg.mozilla.org/mozilla-central/rev/4b88fac7a66d
https://hg.mozilla.org/mozilla-central/rev/d713b06ac1f0
https://hg.mozilla.org/mozilla-central/rev/81b06d750659
https://hg.mozilla.org/mozilla-central/rev/24f82e8e71bd
https://hg.mozilla.org/mozilla-central/rev/d26259d64016
https://hg.mozilla.org/mozilla-central/rev/798fa0bcb00f
https://hg.mozilla.org/mozilla-central/rev/40acd7f334ad
https://hg.mozilla.org/mozilla-central/rev/6e18d1c774b8
https://hg.mozilla.org/mozilla-central/rev/614a4bdd3639

Comment 35

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/about_page_header_grey. r=liuche

Comment 36

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/toolbar_icon_grey. r=liuche

Comment 37

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/tabs_tray_icon_grey. r=liuche

Comment 38

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/tabs_tray_grey_pressed. r=liuche

Comment 39

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/text_and_tabs_tray_grey. r=liuche

Comment 40

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replaces uses of @color/private_toolbar_grey. r=liuche

Comment 41

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/disabled_grey. r=liuche

Comment 42

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/toolbar_grey_pressed. r=liuche

Comment 43

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/toolbar_menu_dark_grey. r=liuche

Comment 44

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1134484 - Replace uses of @color/toolbar_grey. r=liuche