Intermittents browser_animation_toggle_button_updates_playerWidgets.js and browser_animation_ui_updates_when_animation_changes.js | Got pending, expected running

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: RyanVM, Assigned: pbro)

Tracking

({intermittent-failure})

unspecified
Firefox 40
x86
Windows 8.1
intermittent-failure
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed, firefox-esr31 unaffected)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
16:26:12 INFO - 48 INFO TEST-START | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js
16:26:12 INFO - JavaScript error: resource:///modules/WindowsPreviewPerTab.jsm, line 406: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITaskbarTabPreview.invalidate]
16:26:15 INFO - 1424305573070 Browser.Experiments.Experiments TRACE Experiments #0::enabled=true, true
16:26:15 INFO - 1424305573071 Browser.Experiments.Experiments TRACE Experiments #0::Registering instance with Addon Manager.
16:26:15 INFO - 1424305573072 Browser.Experiments.Experiments TRACE Experiments #0::Registering previous experiment add-on provider.
16:26:15 INFO - 1424305573072 Browser.Experiments.Experiments TRACE PreviousExperimentProvider #0::startup()
16:26:15 INFO - 1424305573073 Browser.Experiments.Experiments TRACE Experiments #0::_loadFromCache
16:26:15 INFO - 1424305573078 Browser.Experiments.Experiments TRACE Experiments #0::_loadTask finished ok
16:26:15 INFO - 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_run
16:26:15 INFO - 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_main iteration
16:26:15 INFO - 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_evaluateExperiments
16:26:15 INFO - 1424305573081 Browser.Experiments.Experiments TRACE Experiments #0::_main finished, scheduling next run
16:26:17 INFO - 49 INFO checking window state
16:26:17 INFO - 50 INFO Entering test
16:26:17 INFO - 51 INFO Adding a new tab with URL: 'http://example.com/browser/browser/devtools/animationinspector/test/doc_simple_animation.html'
16:26:17 INFO - 52 INFO Loading the helper frame script chrome://mochitests/content/browser/browser/devtools/animationinspector/test/doc_frame_script.js
16:26:17 INFO - 53 INFO Loading the helper frame script chrome://browser/content/devtools/frame-script-utils.js
16:26:17 INFO - 54 INFO URL 'http://example.com/browser/browser/devtools/animationinspector/test/doc_simple_animation.html' loading complete
16:26:17 INFO - 55 INFO Opening the toolbox with the inspector selected
16:26:17 INFO - 56 INFO Console message: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITaskbarTabPreview.invalidate]" {file: "resource:///modules/WindowsPreviewPerTab.jsm" line: 406}]
16:26:17 INFO - 57 INFO Making sure that the toolbox's frame is focused
16:26:17 INFO - 58 INFO Switching to the animationinspector
16:26:17 INFO - 59 INFO Waiting for the inspector and sidebar to be ready
16:26:17 INFO - 60 INFO Waiting for the animation controller and panel to be ready
16:26:17 INFO - 61 INFO Select an animated node
16:26:17 INFO - 62 INFO Selecting the node for '.animated'
16:26:17 INFO - 63 INFO Click the toggle button to pause all animations
16:26:17 INFO - 64 INFO Console message: 1424305573070 Browser.Experiments.Experiments TRACE Experiments #0::enabled=true, true
16:26:17 INFO - 65 INFO Console message: 1424305573071 Browser.Experiments.Experiments TRACE Experiments #0::Registering instance with Addon Manager.
16:26:17 INFO - 66 INFO Console message: 1424305573072 Browser.Experiments.Experiments TRACE Experiments #0::Registering previous experiment add-on provider.
16:26:17 INFO - 67 INFO Console message: 1424305573072 Browser.Experiments.Experiments TRACE PreviousExperimentProvider #0::startup()
16:26:17 INFO - 68 INFO Console message: 1424305573073 Browser.Experiments.Experiments TRACE Experiments #0::_loadFromCache
16:26:17 INFO - 69 INFO Console message: 1424305573078 Browser.Experiments.Experiments TRACE Experiments #0::_loadTask finished ok
16:26:17 INFO - 70 INFO Console message: 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_run
16:26:17 INFO - 71 INFO Console message: 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_main iteration
16:26:17 INFO - 72 INFO Console message: 1424305573079 Browser.Experiments.Experiments TRACE Experiments #0::_evaluateExperiments
16:26:17 INFO - 73 INFO Console message: 1424305573081 Browser.Experiments.Experiments TRACE Experiments #0::_main finished, scheduling next run
16:26:17 INFO - 74 INFO Checking the selected node's animation player widget's state
16:26:17 INFO - 75 INFO TEST-PASS | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js | The player front's state is paused
16:26:17 INFO - 76 INFO TEST-PASS | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js | The widget's UI is in paused state
16:26:17 INFO - 77 INFO Click the toggle button to play all animations
16:26:17 INFO - 78 INFO Checking the selected node's animation player widget's state again
16:26:17 INFO - 79 INFO TEST-UNEXPECTED-FAIL | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js | The player front's state is running - Got pending, expected running
16:26:17 INFO - Stack trace:
16:26:17 INFO - chrome://mochikit/content/browser-test.js:test_is:854
16:26:17 INFO - chrome://mochitests/content/browser/browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js:null:33
16:26:17 INFO - self-hosted:InterpretGeneratorResume:702
16:26:17 INFO - self-hosted:next:610
16:26:17 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:670:9
16:26:17 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:595:7
16:26:17 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
16:26:17 INFO - 80 INFO TEST-UNEXPECTED-FAIL | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js | The widget's UI is in running state -
16:26:17 INFO - Stack trace:
16:26:17 INFO - chrome://mochitests/content/browser/browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js:null:34
16:26:17 INFO - self-hosted:InterpretGeneratorResume:702
16:26:17 INFO - self-hosted:next:610
16:26:17 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:670:9
16:26:17 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:595:7
16:26:17 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
16:26:17 INFO - 81 INFO Leaving test
16:26:17 INFO - JavaScript error: resource:///modules/WindowsPreviewPerTab.jsm, line 406: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITaskbarTabPreview.invalidate]
16:26:17 INFO - 82 INFO Console message: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITaskbarTabPreview.invalidate]" {file: "resource:///modules/WindowsPreviewPerTab.jsm" line: 406}]
16:26:17 INFO - 83 INFO MEMORY STAT vsize after test: 734273536
16:26:17 INFO - 84 INFO MEMORY STAT vsizeMaxContiguous after test: 8612065501184
16:26:17 INFO - 85 INFO MEMORY STAT residentFast after test: 268226560
16:26:17 INFO - 86 INFO MEMORY STAT heapAllocated after test: 73980992
16:26:17 INFO - 87 INFO TEST-OK | browser/devtools/animationinspector/test/browser_animation_toggle_button_updates_playerWidgets.js | took 5352ms
Comment hidden (Legacy TBPL/Treeherder Robot)
Assignee: nobody → pbrosset
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
(Assignee)

Comment 12

4 years ago
/r/6519 - Bug 1134500 - Intermittent browser_animation_toggle_button_updates_playerWidgets.js; r=grins

Pull down this commit:

hg pull -r 592e05f970c1102bd4f59092e79227afd2de9554 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8587219 - Flags: review?(bgrinstead)
(Assignee)

Comment 14

4 years ago
Just pushed bug 1149711, so this one will need rebasing. Doing this now.
(Assignee)

Comment 15

4 years ago
Comment on attachment 8587219 [details]
MozReview Request: bz://1134500/pbrosset

/r/6519 - Bug 1134500 - Intermittent browser_animation_toggle_button_updates_playerWidgets.js; r=grins

Pull down this commit:

hg pull -r 39886f50d8d5ed7e0998e5a2502a1982d5f3c500 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8587219 [details]
MozReview Request: bz://1134500/pbrosset

https://reviewboard.mozilla.org/r/6517/#review5411

Ship It!
Attachment #8587219 - Flags: review?(bgrinstead) → review+
Comment hidden (Legacy TBPL/Treeherder Robot)
(Reporter)

Comment 19

4 years ago
Backing out the other animation inspector changes that landed prior to this made tests angry. Backed out to try to get things green again.
https://hg.mozilla.org/integration/fx-team/rev/f88ae43fbb9c
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
(Assignee)

Updated

4 years ago
Duplicate of this bug: 1149711
(Assignee)

Updated

4 years ago
Summary: Intermittent browser_animation_toggle_button_updates_playerWidgets.js | The player front's state is running - Got pending, expected running | The widget's UI is in running state → Intermittents browser_animation_toggle_button_updates_playerWidgets.js and browser_animation_ui_updates_when_animation_changes.js | Got pending, expected running
(Assignee)

Comment 24

4 years ago
Re-landed (along with the fix for bug 1149711, since the 2 bugs were really coupled) in https://hg.mozilla.org/integration/fx-team/rev/b6affaeb902e
(Assignee)

Comment 25

4 years ago
Following along test results here: https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=b6affaeb902e
But I'm not expecting any problems with this one, it was merely backed-out because related to bug 1120833, which was the root cause for the backout.
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/b6affaeb902e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
(Reporter)

Comment 30

4 years ago
Based on the date of filing, it appears that this also affects Aurora39 (and possibly Beta38 also). However, this patch doesn't seem overly backportable. What do you think, Patrick?
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox-esr31: --- → unaffected
Flags: needinfo?(pbrosset)
(Assignee)

Comment 31

4 years ago
The code changes in this patch are pretty simple, so if this doesn't apply cleanly on other channels and we still want a fix for the test, I can provide specific patches quickly, just let me know.
Flags: needinfo?(pbrosset)
(Reporter)

Comment 32

4 years ago
If it can be cleanly done, it'd be nice given 38 being the next ESR. Thanks!
(Assignee)

Comment 33

4 years ago
Here's a patch that applies on Aurora cleanly.
Flags: needinfo?(ryanvm)
(Reporter)

Comment 34

4 years ago
Thanks :)
Flags: needinfo?(ryanvm)
(Assignee)

Comment 35

4 years ago
This should be ok for beta.
(Reporter)

Comment 36

4 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/589aafc2bb13
status-firefox38: affected → fixed
Flags: in-testsuite+
(Assignee)

Comment 38

4 years ago
Comment on attachment 8587219 [details]
MozReview Request: bz://1134500/pbrosset
Attachment #8587219 - Attachment is obsolete: true
Attachment #8619536 - Flags: review+

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.