Closed Bug 1149711 Opened 6 years ago Closed 6 years ago

Intermittent browser_animation_ui_updates_when_animation_changes.js | The AnimationPlayerFront is running - Got pending, expected running | The button's state has changed | The smooth timeline animation has been started

Categories

(DevTools :: Inspector, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1134500

People

(Reporter: RyanVM, Assigned: pbro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

10:59:21 INFO - 57 INFO TEST-START | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js
10:59:24 INFO - 58 INFO checking window state
10:59:24 INFO - 59 INFO Entering test
10:59:24 INFO - 60 INFO Adding a new tab with URL: 'http://example.com/browser/browser/devtools/animationinspector/test/doc_simple_animation.html'
10:59:24 INFO - 61 INFO Loading the helper frame script chrome://mochitests/content/browser/browser/devtools/animationinspector/test/doc_frame_script.js
10:59:24 INFO - 62 INFO Loading the helper frame script chrome://browser/content/devtools/frame-script-utils.js
10:59:24 INFO - 63 INFO URL 'http://example.com/browser/browser/devtools/animationinspector/test/doc_simple_animation.html' loading complete
10:59:24 INFO - 64 INFO Opening the toolbox with the inspector selected
10:59:24 INFO - 65 INFO Making sure that the toolbox's frame is focused
10:59:24 INFO - 66 INFO Switching to the animationinspector
10:59:24 INFO - 67 INFO Waiting for the inspector and sidebar to be ready
10:59:24 INFO - 68 INFO Waiting for the animation controller and panel to be ready
10:59:24 INFO - 69 INFO Select the test node
10:59:24 INFO - 70 INFO Selecting the node for '.animated'
10:59:24 INFO - 71 INFO Get the player widget
10:59:24 INFO - 72 INFO Pause the animation via the content DOM
10:59:24 INFO - 73 INFO Sending message Test:ToggleAnimationPlayer to content
10:59:24 INFO - 74 INFO Expecting message Test:ToggleAnimationPlayer from content
10:59:24 INFO - 75 INFO Wait for the next state update
10:59:24 INFO - 76 INFO TEST-PASS | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The AnimationPlayerFront is paused
10:59:24 INFO - 77 INFO TEST-PASS | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The button's state has changed
10:59:24 INFO - 78 INFO TEST-PASS | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The smooth timeline animation has been stopped
10:59:24 INFO - 79 INFO Play the animation via the content DOM
10:59:24 INFO - 80 INFO Sending message Test:ToggleAnimationPlayer to content
10:59:24 INFO - 81 INFO Expecting message Test:ToggleAnimationPlayer from content
10:59:24 INFO - 82 INFO Wait for the next state update
10:59:24 INFO - 83 INFO TEST-UNEXPECTED-FAIL | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The AnimationPlayerFront is running - Got pending, expected running
10:59:24 INFO - Stack trace:
10:59:24 INFO - chrome://mochikit/content/browser-test.js:test_is:920
10:59:24 INFO - chrome://mochitests/content/browser/browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js:null:44
10:59:24 INFO - self-hosted:next:625
10:59:24 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:736:9
10:59:24 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:659:7
10:59:24 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
10:59:24 INFO - 84 INFO TEST-UNEXPECTED-FAIL | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The button's state has changed -
10:59:24 INFO - Stack trace:
10:59:24 INFO - chrome://mochitests/content/browser/browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js:null:45
10:59:24 INFO - self-hosted:next:625
10:59:24 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:736:9
10:59:24 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:659:7
10:59:24 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
10:59:24 INFO - 85 INFO TEST-UNEXPECTED-FAIL | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | The smooth timeline animation has been started -
10:59:24 INFO - Stack trace:
10:59:24 INFO - chrome://mochitests/content/browser/browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js:null:46
10:59:24 INFO - self-hosted:next:625
10:59:24 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:736:9
10:59:24 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:659:7
10:59:24 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
10:59:24 INFO - 86 INFO Leaving test
10:59:24 INFO - 87 INFO MEMORY STAT vsize after test: 992067584
10:59:24 INFO - 88 INFO MEMORY STAT residentFast after test: 218992640
10:59:24 INFO - 89 INFO MEMORY STAT heapAllocated after test: 93321000
10:59:24 INFO - 90 INFO TEST-OK | browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js | took 3493ms
Flags: needinfo?(pbrosset)
The fix I have for bug 1137771 is the same needed for this bug. So I want to land that one first and then just reuse the fix for this other failing test.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Depends on: 1137771
Flags: needinfo?(pbrosset)
/r/6515 - Bug 1149711 - Intermittent browser_animation_ui_updates_when_animation_changes.js; r=bgrins

Pull down this commit:

hg pull -r 9a10b456d3e50f2f652a72bd5096a1070cc43b86 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8587211 - Flags: review?(bgrinstead)
Comment on attachment 8587211 [details]
MozReview Request: bz://1149711/pbrosset

https://reviewboard.mozilla.org/r/6513/#review5405

Please update the commit message to also include a description of hte change

::: browser/devtools/animationinspector/test/browser_animation_ui_updates_when_animation_changes.js
(Diff revision 1)
> +  let onPaused = waitForStateCondition(player, ({playState}) => playState === "paused");

Just a thought: looking at the existing tests it looks like waitForStateCondition could take a string instead of a function as the second argument (all uses are just checking playState directly).
Attachment #8587211 - Flags: review?(bgrinstead) → review+
https://reviewboard.mozilla.org/r/6513/#review5407

> Just a thought: looking at the existing tests it looks like waitForStateCondition could take a string instead of a function as the second argument (all uses are just checking playState directly).

I'd like to keep this function more generic because I've got other patches coming up later that need other properties of the state.
I could however add a simpler waitForPlayState(player, playState) helper that accepts a string and just calls waitForStateCondition.
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #7)
> https://reviewboard.mozilla.org/r/6513/#review5407
> 
> > Just a thought: looking at the existing tests it looks like waitForStateCondition could take a string instead of a function as the second argument (all uses are just checking playState directly).
> 
> I'd like to keep this function more generic because I've got other patches
> coming up later that need other properties of the state.
> I could however add a simpler waitForPlayState(player, playState) helper
> that accepts a string and just calls waitForStateCondition.

That seems like a good idea
I've added the helper function discussed in comment 7, rebased, tested again, and pushed to fx-team: https://hg.mozilla.org/integration/fx-team/rev/527c548ff03c
Backed out because this was blocking bug 1120833 from being backed out.
https://hg.mozilla.org/integration/fx-team/rev/0cb8a23d435d
This and bug 1134500 were both backed out together because they essentially touch the same files, to do more or less the same thing.
They're both about intermittent test failures, and the fix for these 2 tests is the same.
So I'm marking this one as duplicate and will re-land both fixes as one in bug 1134500.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1134500
Attachment #8587211 - Attachment is obsolete: true
Attachment #8619926 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.