1134532 - Pages can lock the urlbar from scrolling on screen

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Comment 1

[Brian Nicholson (:bnicholson)]

Can you elaborate on what happens here? Any STR?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/450

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8604492 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/450

Dropped some comments on the PR. I like the idea of using a custom gesture recognizer to capture the touch events to give us more control over the behaviour. I would double check to make sure all the click events on links on web content still work though.

Comment 4

[Wesley Johnston (:wesj)]

Update the PR with your nits. Clicking works fine. I did see this lockup once again though...

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8604492 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/450

This feels awesome. After my changes, I noticed that there was jank when zooming into the web content but it seems like this custom gesture handling solves that :) Go ahead and land this patch down and I'll update mine with these changes.

Comment 6

[Wesley Johnston (:wesj)]

Merged.

Comment 7

[Stephan Leroux [:sleroux]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1166731 for link scrolling bug.

Merged PR.

Comment 8

[Stephan Leroux [:sleroux]]

Bah wrong ticket...

Comment 9

[Wesley Johnston (:wesj)]

This regressed some stuff. Going to work out a "backout" tomorrow morning.

Comment 10

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/484

This backs this out. I actually would feel sorta OK just fixing up the canBePreventedBy method, but I think this is probably safer.

Comment 11

[Stephan Leroux [:sleroux]]

Comment on attachment 8608501 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/484

Ya I had a branch open that fixes another issue related with the reordering of the super calls which was causing issues on master after the build was cut but I feel safer for now landing this patch instead. I'll land this in so we can cut a hotfix build for the beta testers.

Comment 12

[Stephan Leroux [:sleroux]]

Merged.