Closed Bug 1134680 Opened 5 years ago Closed 5 years ago

Show "short_name" in Settings app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S7 (6mar)
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: benfrancis, Assigned: sfoster)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Now that we are adding support for short_name all over the place, we may want to show both the full name and short name in the Settings app so that users know what both names are for a given app.
Paul, what are the security requirements here?

Francis, what are the UX requirements here?
Flags: needinfo?(ptheriault)
Flags: needinfo?(fdjabri)
My feeling is that it should be ok to only show the short name of the app in the Settings app, as this is how it appears to users on the home screen, unless there is some security requirement to show both. 

Jenny, what do you think? Please see bug 1001861 for background.
Flags: needinfo?(fdjabri) → needinfo?(jelee)
I just spotted Paul's original comment, I was sure he mentioned something about this https://bugzilla.mozilla.org/show_bug.cgi?id=1001861#c2
Comment on attachment 8567374 [details] [review]
[gaia] sfoster:settings-short-name-bug-1134680 > mozilla-b2g:master

attachment #85673474 just uses short_name vs. name when available in the manifest. 

That's the simple answer. To use both the short and long name here we'll need to do something like:

[icon] short_name (long name) 

..and expect long name to be truncated, so you would see "[icon] short_name (long name.."

This would need to be localized though I imagine, as the parentheses and conventions for constructing this kind of string are going to vary. Using both could be a follow-up, once discussion in bug 1001861 has produced a definitive answer.
Attachment #8567374 - Flags: review?(arthur.chen)
Hi Francis,

I'm ok with showing only short names in Settings. Basically, the place where user sees app name in Settings is App permission. However, not every app is shown in App permission panel, only the ones with permission settings. So if we are looking for a solution to display both app full name and short name, we will need something like Application Manager. Thanks!
Flags: needinfo?(jelee)
Comment on attachment 8567374 [details] [review]
[gaia] sfoster:settings-short-name-bug-1134680 > mozilla-b2g:master

Looks good to me, thanks.
Attachment #8567374 - Flags: review?(arthur.chen) → review+
Paul, the UX consensus seems to be that we *dont* need to show both the short name and long name - here or anywhere in Gaia. The long name (when both name and short_name exist in the manifest) will only be used when searching for an app via the Rocketbar, and in the marketplace. Attachment #8567374 [details] is a r+'d patch to just favor short_name when its available in the Settings > App Permissions screens. Are you ok with this outcome, or do we need to revisit the decision? (Also see discussion in bug 1001861)
Summarizing discussion with pauljt (ptheriault) in IRC: As long as we are consistent about which name property we use for an app, we don't need to show both in Settings. 

We do currently use the name property only in the install prompt and installed toaster though, I'll file separate bugs for those
Flags: needinfo?(ptheriault)
Keywords: checkin-needed
No longer blocks: 1137498
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
This should be 2.2+ since it's blocking a 2.2+ bug 1001861

Hi Sam, could you request gaia 2.2 uplift approval for this patch? Thanks.
blocking-b2g: --- → 2.2+
Flags: needinfo?(sfoster)
Comment on attachment 8567374 [details] [review]
[gaia] sfoster:settings-short-name-bug-1134680 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Support for 'short_name' property in app manifest (bug 1001861)
[User impact] if declined: The (long) name property will be used in the settings app instead of the short_name seen elsewhere (homescreen, task manager)
[Testing completed]: Tested on device, Gaia-Try
[Risk to taking this patch] (and alternatives if risky): V. low risk, this is a trivial patch to the Settings app to add support for the (optional) short_name manifest property
[String changes made]: None
Flags: needinfo?(sfoster)
Attachment #8567374 - Flags: approval-gaia-v2.2?
Attachment #8567374 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
v2.2: https://github.com/mozilla-b2g/gaia/commit/818d702597cbed900df5693e79c0e614137c32fb
Assignee: nobody → sfoster
Target Milestone: --- → 2.2 S7 (6mar)
Sam, Jenny, we are showing keyboard app names in Settings > Keyboards as well. Could you weight on that and maybe file bugs on these panel too. I don't think this is a complete fix.
Flags: needinfo?(sfoster)
Flags: needinfo?(jelee)
Blocks: 1140060
(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #14)
> Sam, Jenny, we are showing keyboard app names in Settings > Keyboards as
> well. Could you weight on that and maybe file bugs on these panel too. I
> don't think this is a complete fix.

Thanks for spotting that. I filed bug 1140060 for the keyboard apps.
Flags: needinfo?(sfoster)
I will follow up in bug 1140060. Thanks!
Flags: needinfo?(jelee)
Whiteboard: [systemsfe]
Update summary to avoid confusing.
Verified with below build and test app.

* 2.2
Build ID               20150326164141
Gaia Revision          6d0174e28576f2f93e696a43d1ac3b03340117f6
Gaia Date              2015-03-26 21:47:33
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/820c2f2e817a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.201153
Firmware Date          Thu Mar 26 20:12:05 EDT 2015
Bootloader             L1TC000118D0

* Master
Build ID               20150326160206
Gaia Revision          525c341254e08f07f90da57a4d1cd5971a3cc668
Gaia Date              2015-03-26 16:34:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59554288b4eb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.193247
Firmware Date          Thu Mar 26 19:32:58 EDT 2015
Bootloader             L1TC100118D0

* Test App URL: http://mozilla-b2g.github.io/qa-testcase-data/hermescheng/short_name-support/index.html
Status: RESOLVED → VERIFIED
Summary: Show both "name" and "short_name" in Settings app → Show "short_name" in Settings app
You need to log in before you can comment on or make changes to this bug.