Provide an opt in for search suggestions in the search awesome screen

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wesj, Assigned: bnicholson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
We make you opt in on Android. We should on iOS too.
(Reporter)

Updated

4 years ago
Blocks: 1127022
(In reply to Wesley Johnston (:wesj) from comment #0)
> We make you opt in on Android. We should on iOS too.

Can we get product input on this?  Right now, we're using "default search engine" for search suggestions, and you can't turn them off.  (And we don't let you opt in.)  I just landed Bug 1130527, which made the default search engine always exist, so you really can't turn them off.

The mocks from darrin don't include disabling search suggestions (see [1]).  Is this actually a feature we want?  Is it v1?

[1] https://mozilla.invisionapp.com/share/HA254M642#/screens/64313421?maintainScrollPosition=false
Flags: needinfo?(wjohnston)
Flags: needinfo?(mark.finkle)
Flags: needinfo?(krudnitski)
Flags: needinfo?(dhenein)
OS: Mac OS X → iOS 8
Hardware: x86 → All
It actually *is* a feature we want. It is part of our 'giving users control of their privacy' story, in that some users don't actually want their search queries to be given over to providers. That's why we implemented it the way we did on Android - it was that balance of the usefulness of suggestions with those that wanted the control of what they were sending over to providers.

how difficult would it be to implement search suggestions in the same manner as Android (ie prompting the users to turn them on)?
Flags: needinfo?(krudnitski)
I agree with Karen. This feature is why we make Firefox.
Flags: needinfo?(mark.finkle)
I'm glad we all think this is valuable \o/  Technically, I see no reason we can't do exactly as we do on Android: prompting in the search panel and exposing the option (and the suggestion provider) in the settings panel.  I've modified this ticket to track prompting in the search panel and will file the settings panel ticket.
Summary: Provide an opt in for search suggestions → Provide an opt in for search suggestions in the search awesome screen
(Reporter)

Updated

4 years ago
Flags: needinfo?(wjohnston)
Created attachment 8572087 [details]
AwesomeScreen - Suggestion Opt-in.png
Flags: needinfo?(dhenein)
(Assignee)

Updated

4 years ago
Assignee: nobody → bnicholson
(Assignee)

Comment 6

4 years ago
Created attachment 8576452 [details] [review]
Pull request
Attachment #8576452 - Flags: review?(sarentz)
Comment on attachment 8576452 [details] [review]
Pull request

Looks good!
Attachment #8576452 - Flags: review?(sarentz) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.