1134706 - Provide an opt in for search suggestions in the search awesome screen

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

We make you opt in on Android. We should on iOS too.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Wesley Johnston (:wesj) from comment #0)
> We make you opt in on Android. We should on iOS too.

Can we get product input on this?  Right now, we're using "default search engine" for search suggestions, and you can't turn them off.  (And we don't let you opt in.)  I just landed Bug 1130527, which made the default search engine always exist, so you really can't turn them off.

The mocks from darrin don't include disabling search suggestions (see [1]).  Is this actually a feature we want?  Is it v1?

[1] https://mozilla.invisionapp.com/share/HA254M642#/screens/64313421?maintainScrollPosition=false

Comment 2

[Karen Rudnitski [:kar]]

It actually *is* a feature we want. It is part of our 'giving users control of their privacy' story, in that some users don't actually want their search queries to be given over to providers. That's why we implemented it the way we did on Android - it was that balance of the usefulness of suggestions with those that wanted the control of what they were sending over to providers.

how difficult would it be to implement search suggestions in the same manner as Android (ie prompting the users to turn them on)?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree with Karen. This feature is why we make Firefox.

Comment 4

[Nick Alexander :nalexander [he/him]]

I'm glad we all think this is valuable \o/  Technically, I see no reason we can't do exactly as we do on Android: prompting in the search panel and exposing the option (and the suggestion provider) in the settings panel.  I've modified this ticket to track prompting in the search panel and will file the settings panel ticket.

Comment 5

[Darrin Henein [:darrin]]

Attachment: AwesomeScreen - Suggestion Opt-in.png

Comment 6

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8576452 [details] [review]
Pull request

Looks good!