1138122 - Allow user to opt-in/opt-out of search suggestions and configure the search suggestion provider in settings panel

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks exposing a setting for the user to opt-in/opt-out of search suggestions, and to change the search suggestion provider.  It is follow-up and clarification to the work landed in Bug 1130527.

Comment 1

[Nick Alexander :nalexander [he/him]]

darrin: this follows the discussion from https://bugzilla.mozilla.org/show_bug.cgi?id=1130527#c3.  Desktop has a toggle for providing search suggestions, and a drop-down for the list of search suggestion providers.

How would you like the toggle and search suggestion provider UI to look?  Right now we distinguish the first search engine and make it the search suggestion provider.

Comment 2

[Darrin Henein [:darrin]]

For now, lets do the following:


Default Search Engine
---------------------------------
Yahoo                          >
---------------------------------
Show Search Suggestions?    (  O)
---------------------------------

Quick Search Engines
---------------------------------
Google                      (  O)
---------------------------------
Bing                        (O  )
---------------------------------
Amazon                      (  O)
---------------------------------
Twitter                     (  O)
---------------------------------

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/199

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8573611 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/199

LGTM

Comment 5

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/4a3260e1e8937427c8185e9c7716accdc0460d5e