1134771 - crash in mozilla::FrameLayerBuilder::GetPaintedLayerScaleForFrame(nsIFrame*)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[alex_mayorga]

This bug was filed from the Socorro interface and is 
report bp-5276cda8-70c8-464d-a890-d9ba12150219.
=============================================================

Comment 1

[Mats Palmgren (inactive)]

Low-volume crash.  Looks like it started in v35.  All platforms are affected.
The stack for bp-5276cda8-70c8-464d-a890-d9ba12150219 is:

mozilla::FrameLayerBuilder::GetPaintedLayerScaleForFrame(nsIFrame*)
mozilla::ScrollFrameHelper::ScrollToImpl(nsPoint, nsRect const&, nsIAtom*)
mozilla::ScrollFrameHelper::ReflowFinished()
PresShell::HandlePostedReflowCallbacks(bool)
PresShell::DidDoReflow(bool, bool)
PresShell::ProcessReflowCommands(bool)
PresShell::FlushPendingNotifications(mozilla::ChangesToFlush)
...


Other crashes have a different stack leading up to ScrollToImpl,
e.g. bp-ade4eaca-c30a-48a0-b5a3-7264d2150127

mozilla::FrameLayerBuilder::GetPaintedLayerScaleForFrame(nsIFrame*)
mozilla::ScrollFrameHelper::ScrollToImpl(nsPoint, nsRect const&, nsIAtom*)
mozilla::ScrollFrameHelper::AsyncScrollCallback(mozilla::ScrollFrameHelper*, mozilla::TimeStamp)
mozilla::ScrollFrameHelper::AsyncScroll::WillRefresh(mozilla::TimeStamp)
nsRefreshDriver::Tick(__int64, mozilla::TimeStamp)
nsRefreshDriver::DoTick()
nsRefreshDriver::WillRefresh(mozilla::TimeStamp)
nsRefreshDriver::Tick(__int64, mozilla::TimeStamp)
nsRefreshDriver::DoTick()
nsRefreshDriver::FinishedWaitingForTransaction()
nsRefreshDriver::NotifyTransactionCompleted(unsigned __int64)
mozilla::layers::ClientLayerManager::DidComposite(unsigned __int64)
...

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Updating crash signature to reflect changes to signature generation made in bug 1269817 (although reports older than a week will not be reprocessed), and adding dependency to ShutDownKill metabug.

(These probably shouldn't all be separate bugs, but I'm not going to fix that up in a mass-change.)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Note that the crash in comment 0 and the first crash in comment 1 are ShutDownKill crashes, which now have separate signatures.

(see the ipc_channel_error field in the Metadata tab.)

Mats, maybe worth filing a separate bug for the second crash in comment 1?

Comment 5

[Mats Palmgren (inactive)]

Or we could re-purpose this bug to be about the non-ShutDownKill crash since
the stack related to the ShutDownKill crash doesn't indicate a Layout bug.
(it's just some random (valid) stack that got intentionally aborted IIUC)

Anyway, it might be better to wait a few weeks to see if there are any new
GetPaintedLayerScaleForFrame crashes after ShutDownKill related ones have
forked to the new signature.  (keeping the needinfo to check this later)

Comment 6

[Mats Palmgren (inactive)]

We still have recent crash reports coming in for GetPaintedLayerScaleForFrame:
bp-563bd511-7d29-46a1-b9ab-c635d2160506
bp-b30b8c1e-25e1-43c5-9039-e54d32160527
so I think the original (Layout) bug here still exist (the first stack in
comment 1 at least).

Comment 7

[alex_mayorga]

[@ @0x0 | mozilla::FrameLayerBuilder::GetPaintedLayerScaleForFrame ] no longer shows.


[@ mozilla::FrameLayerBuilder::GetPaintedLayerScaleForFrame ] affects release and beta, 45 total crashes in the past week.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 10

[Calixte Denizet (:calixte)]

There are still some crashes so reopen it.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 5 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit auto_nag documentation.

Comment 12

[Timothy Nikkel (:tnikkel)]

This code no longer exists at that location. No crashes at the new location.