1134913 - Disable EME voucher generation on Win64

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Bug 1131798 was backed out because the patch to the EME voucher generator can't handle Win64 binaries. We need bug 1131798 urgently, so we should just disable running the voucher generator on Win64 so that bug 1131798 can land, and follow up to re-enable it on Win64.

We should only be running the gen-eme-voucher.py on 32bit Windows builds.

Comment 1

[Rail Aliiev [:rail]]

Can we disable it in https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/make-eme.mk#11?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

That looks like the place.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Let's see...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf4e643db1a

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Don't run gen-eme-voucher.py pn Win64, since it isn't designed to handle it anyway.

Try looks good.

Thanks for the tip Rail.

Comment 5

[Rail Aliiev [:rail]]

Yay, no problem.

Comment 6

[(not currently active) Ted Mielczarek]

Please make sure to file a follow-up and have it block bug 558448?

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b0531bd1e44

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Please make sure to file a follow-up and have it block bug 558448?

Filed bug 1135320.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b0531bd1e44

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Needs uplift.

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8567004 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: We'll break the build when we land Bug 1131798, which is required for Adobe EME to work.
[Describe test coverage new/current, TreeHerder]: We haven't yet setup an automated test yet as this requires downloading Adobe's CDM over the internet, and our existing test harnesses can't do that. We're going to setup an external test that covers this.
[Risks and why]: Low; only touches affects third party plugins.
[String/UUID change made/needed]: None

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8567004 [details] [diff] [review]
Patch

Taking this as a prereq for bug 1131798. Beta+

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/67df6f1dbe4f