Closed Bug 1134913 Opened 5 years ago Closed 5 years ago
Disable EME voucher generation on Win64
Bug 1131798 was backed out because the patch to the EME voucher generator can't handle Win64 binaries. We need bug 1131798 urgently, so we should just disable running the voucher generator on Win64 so that bug 1131798 can land, and follow up to re-enable it on Win64. We should only be running the gen-eme-voucher.py on 32bit Windows builds.
Can we disable it in https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/make-eme.mk#11?
That looks like the place.
Don't run gen-eme-voucher.py pn Win64, since it isn't designed to handle it anyway. Try looks good. Thanks for the tip Rail.
Attachment #8567004 - Flags: review?(ted)
Yay, no problem.
Attachment #8567004 - Flags: review?(ted) → review+
Please make sure to file a follow-up and have it block bug 558448?
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6) > Please make sure to file a follow-up and have it block bug 558448? Filed bug 1135320.
Comment on attachment 8567004 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: EME [User impact if declined]: We'll break the build when we land Bug 1131798, which is required for Adobe EME to work. [Describe test coverage new/current, TreeHerder]: We haven't yet setup an automated test yet as this requires downloading Adobe's CDM over the internet, and our existing test harnesses can't do that. We're going to setup an external test that covers this. [Risks and why]: Low; only touches affects third party plugins. [String/UUID change made/needed]: None
Attachment #8567004 - Flags: approval-mozilla-beta?
Comment on attachment 8567004 [details] [diff] [review] Patch Taking this as a prereq for bug 1131798. Beta+
Attachment #8567004 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.