1135320 - Re-enable gen-eme-voucher.py on Win64

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I disabled generating the EME voucher in bug 1134913, as the voucher generator does not handle a Win64 binary. Once Adobe provide a patch so it can handle Win64 binaries, we should re-enable it on Win64.

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1135320.patch

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bbfaf852ef

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8647267 [details] [diff] [review]
1135320.patch

Review of attachment 8647267 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but someone more qualified should r+ing this code.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8647267 [details] [diff] [review]
1135320.patch

Review of attachment 8647267 [details] [diff] [review]:
-----------------------------------------------------------------

Technically, this is a backout of bug 1134913, you don't really need a review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6edef7f242

Comment 5

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/7d6edef7f242

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 8647267 [details] [diff] [review]
1135320.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: 64-bit Firefox 42 users won't be able to use Netflix EME without the voucher.bin signature file generated by this patch.
[Describe test coverage new/current, TreeHerder]: This patch landed in Nightly 43 and has been tested since then.
[Risks and why]: Low risk because the voucher.bin file does not affect any Firefox code except EME and without this patch EME doesn't work at all.
[String/UUID change made/needed]: None

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8647267 [details] [diff] [review]
1135320.patch

Sure, should be in 42 beta 4.

Comment 8

[Chris Peterson [:cpeterson]]

Thanks! checkin-needed for mozilla-beta

Comment 9

[Sylvestre Ledru [:Sylvestre]]

For uplift requests, approval-mozilla-beta+ is enough to have uplift done by the sheriffs :)

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5d6ae6a10a0a