Closed
Bug 1134923
Opened 9 years ago
Closed 9 years ago
Remove NS_Alloc/NS_Realloc/NS_Free
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
135.09 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Possibly relevant discussion in bug 958212. At this point, I don't think we need to keep the distinction for a "XPCOM" allocator. We're already doing all sorts of combination of allocators, and our increased use of "standard" C++ doesn't make the distinction any easier. A case could be made that a "XPCOM" allocator is still interesting for embedding and components, but I'd argue those already need mozalloc.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8566907 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8566907 [details] [diff] [review] Remove NS_Alloc/NS_Realloc/NS_Free Gah, this one fails because mozalloc is not available to the standalone glue... I have to re-reorder my queue.
Attachment #8566907 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
They are kept around for the sake of the standalone glue, which is used for e.g. webapprt, which doesn't have direct access to jemalloc, and thus still needs a wrapper to go through the xpcom function list and get to jemalloc from there.
Attachment #8566907 -
Attachment is obsolete: true
Attachment #8599708 -
Flags: review?(nfroyd)
Updated•9 years ago
|
Attachment #8599708 -
Flags: review?(nfroyd) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7bc6ca149561
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•