1134920 - Remove nsMemory::Alloc/Free/Realloc

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

We have too many allocator wrappers.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove nsMemory::Alloc/Free/Realloc

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8566887 [details] [diff] [review]
Remove nsMemory::Alloc/Free/Realloc

Ah, I reordered my patch queue, and forgot to s/free/moz_free/ in this patch.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Remove nsMemory::Alloc/Free/Realloc

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8566901 [details] [diff] [review]
Remove nsMemory::Alloc/Free/Realloc

This patch reordering thing was a mistake. This really all needs to go on top of mozalloc being merged in mozglue.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free

Comment 6

[Mike Hommey [:glandium]]

Attachment: Remove nsMemory::Alloc/Realloc/Free

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8584192 [details] [diff] [review]
Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free

Review of attachment 8584192 [details] [diff] [review]:
-----------------------------------------------------------------

We should really be using new/delete/smart pointers for some of these. :(  (Not your problem.)

Thank you for fixing the comments as well.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e60e056a230c
https://hg.mozilla.org/integration/mozilla-inbound/rev/da6cbd725f5f

Comment 9

[Mike Hommey [:glandium]]

At least this needs some update:
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIMemory

Like with bug 1138293. I want to discuss how best to update the doc(s).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e60e056a230c
https://hg.mozilla.org/mozilla-central/rev/da6cbd725f5f

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b2da7ea0f9

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c0b2da7ea0f9