1134954 - Disable safebrowsing updates in safe mode

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1134858. This bug would have been less bad if we didn't check safebrowsing in safe mode.

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

https://tbpl.mozilla.org/?tree=Try&rev=e893c6cfcbb4

Comment 2

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: Disable Safe Browsing in safe mode (

Comment 3

[François Marier [:francois]]

Comment on attachment 8573429 [details] [diff] [review]
Disable Safe Browsing in safe mode (

Review of attachment 8573429 [details] [diff] [review]:
-----------------------------------------------------------------

Noting that if we can't figure out whether or not we're in safe-mode, we assume that we're not and we leave SafeBrowsing ON. That looks right to me.

Comment 4

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8573429 [details] [diff] [review]
Disable Safe Browsing in safe mode (

Review of attachment 8573429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sane to me.

Comment 5

[[:mmc] Monica Chew (no longer reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf124d9e2441

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cf124d9e2441

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Attachment: webForg.png

Went through verification using the following m-c build:
* http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-03-09-03-02-24-mozilla-central/

Test Cases Used:

* enabled "browser.safebrowsing.debug;true"
* ensured that the listmanager is checking for updates when launching fx when not using safe mode:
** listmanager: 16:40:21 GMT-0400 (Eastern Standard Time): update success for goog-phish-shavar,goog-malware-shavar,goog-badbinurl-shavar,goog-downloadwhite-digest256 from https://safebrowsing.google.com/safebrowsing/downloads?client=navclient-auto-ffox&appver=39.0a1&pver=2.2&key=AIzaSyD-s-mXL4mBzF7KMRkhTCIbG2RKnRGXzJc
* ensured that disabling/enabling "browser.safebrowsing.downloads.enabled" will re-check to see if there's any updates available
* ensured that disabling/enabling "browser.safebrowsing.downloads.enabled" will NOT re-check updates while in safe mode:
** SafeBrowsing: 16:55:04 GMT-0400 (Eastern Standard Time): initializing safe browsing URLs, client id  navclient-auto-ffox (no other information/logs after that while in safe mode)
* ensured that "Reported Web Forgery!" warning is correctly appearing when using http://www.itisatrap.org/firefox/its-a-trap.html

Possible Issues:

Issue #1:

When starting the browser in safe mode, the following error message appears in the browser console:
* NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]

Issue #2:

While in safe mode, http://www.itisatrap.org/firefox/its-a-trap.html isn't producing the "Reported Web Forgery!" alert box. See the attached screenshot.

Issue #3: (Created Bug # 1141363)

While in safe mode, completing a download will crash fx every single time:
* Firefox 39.0a1 Crash Report [@ PendingDBLookup::LookupSpecInternal(nsACString_internal const&)]
** https://crash-stats.mozilla.com/report/index/c6b7db15-8291-44bb-a964-c71582150309
** https://crash-stats.mozilla.com/report/index/12730e59-1338-4aeb-b543-d76fe2150309

Monica, are issues #1 & #2 legitimate issues or are these expected?

Comment 8

[[:mmc] Monica Chew (no longer reading bugmail)]

#1 is not legitimate, #2 is working as expected -- we won't ever show the interstitial if the safebrowsing service is not initialized.

Thanks for filing issue #3.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Thanks Monica!