fx crashing when download is being completed while in safe mode

VERIFIED FIXED in Firefox 39

Status

()

Toolkit
Safe Browsing
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: kjozwiak, Assigned: mmc)

Tracking

39 Branch
mozilla39
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(firefox39 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
When a download is about to be completed, fx crashes every single time. This is probably happening when the .exe is being scanned via the phishing/safe browsing protection mechanism.

* Firefox 39.0a1 Crash Report [@ PendingDBLookup::LookupSpecInternal(nsACString_internal const&)]
** https://crash-stats.mozilla.com/report/index/c6b7db15-8291-44bb-a964-c71582150309
** https://crash-stats.mozilla.com/report/index/12730e59-1338-4aeb-b543-d76fe2150309

STR:

- download the latest m-c
- select the hamburger menu -> Open Help Menu -> Restart with Add-ons Disabled and select "Safe Mode" when prompted
- once fx re-launches in safe mode, download something from http://ftp.mozilla.org/pub/mozilla.org/
- once the download is completed, you'll receive the crash instantly
Created attachment 8574964 [details] [diff] [review]
Check to see we can get UrlClassifierDBService before using it (
Assignee: nobody → mmc
Status: NEW → ASSIGNED
Comment on attachment 8574964 [details] [diff] [review]
Check to see we can get UrlClassifierDBService before using it (

Review of attachment 8574964 [details] [diff] [review]:
-----------------------------------------------------------------

This would explain the null pointer violation. I also searched http://mxr.mozilla.org/mozilla-central/search?string=NS_URLCLASSIFIERDBSERVICE_CONTRACTID%2C to make sure we are checking the return value for getting the service elsewhere. (I missed this in bug 1134954 because I only searched for NS_URICLASSIFIER, the other interface name for this service).
Attachment #8574964 - Flags: review?(francois)
r+ from sworkman in person
Created attachment 8574967 [details] [diff] [review]
Check to see we can get UrlClassifierDBService before using it (
Comment on attachment 8574967 [details] [diff] [review]
Check to see we can get UrlClassifierDBService before using it (

r+ from sworkman in person
Attachment #8574967 - Flags: review+
Attachment #8574964 - Attachment is obsolete: true
Attachment #8574964 - Flags: review?(francois)
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab55fc022a19
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Reporter)

Comment 9

3 years ago
Went through verification using the following build:
* http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-03-12-03-02-48-mozilla-central/

Test Cases used:

- ensured enabling/disabling "browser.safebrowsing.downloads.enabled" while not in safe mode successfully checks for table updates
- ensured enabling/disabling "browser.safebrowsing.downloads.enabled" in safe mode doesn't attempt to fetch table updates
- Downloaded several file types (.exe, .dmg, .tar.bz2, .jpg, Chrome executable, Skype executable) without issues
- ensured that you can switch between safe mode/none-safe mode without problems

OS's Used:

Ubuntu 14.04.1 x64 - PASSED
Windows 8.1 x64 - PASSED
OSX 10.10.2 x64 - PASSED
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
You need to log in before you can comment on or make changes to this bug.