1134991 - getUserMedia Audio does not work on Android 2.3 devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Flaviu Cos]

Attachment: logs.txt

Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 38.0a1 (2015-02-19);

Steps to reproduce:
1. Go to http://mozilla.github.com/webrtc-landing/gum_test.html
2. Select 'Audio & Video';
3. Choose 'Share' option from the doorhanger.

Expected result:
The camera and microphone starts.

Actual result:
'InternalError: Starting audio failed' error is displayed.

Notes:
I attached the logs from LogCat.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Maybe this?
02-23 11:22:37.450: E/libOpenSLES(1011): Cannot set recording preset: unknown or invalid preset

Comment 2

[Gian-Carlo Pascutto [:gcp]]

SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION is only avaiable from API level 14 and above but the new opensles code from upstream uses it.

There's similar places in WebRtcAudioRecord.java where backwards compatibility code got removed.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Attachment: Failure to set up voice communication mode in OpenSLES should not be fatal

Don't exit OpenSLES initialization if setting the voice mode fails.
It doesn't exist on pre-API level 14 devices.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://tbpl.mozilla.org/?tree=Try&rev=16e42923a664

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92b051f1fb3f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/92b051f1fb3f

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8567195 [details] [diff] [review]
Failure to set up voice communication mode in OpenSLES should not be fatal

Approval Request Comment
[Feature/regressing bug #]: webrtc version 40 import

[User impact if declined]: no audio on Android 2.3

[Describe test coverage new/current, TreeHerder]: manual testing; I think many 2.3 tests are disabled

[Risks and why]: Pretty low risk regression fix; 

[String/UUID change made/needed]: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8567195 [details] [diff] [review]
Failure to set up voice communication mode in OpenSLES should not be fatal

Accepting for aurora since it's early in the cycle and fixes a regression.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6267d292aab3

Comment 10

[Flaviu Cos]

Verified as fixed in builds:
- 39.0a1 2015-02-26;
- 38.0a2 2015-02-26;
Device: Samsung Galaxy R (Android 2.3.4).