Update WebRTC code to webrtc.org stable branch 40

RESOLVED FIXED in mozilla38

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Assignee)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #987979 +++

webrtc.org stable branch 40 is being used in Chrome 40, to be released soon.
(They made the stable branch match the chrome release, finally)

To be done using the process is being documented here:
https://wiki.mozilla.org/Media/WebRTC/Updating_Process

New AEC code, many changes to content load/analysis code, VP9 support.  Lots of cleanup in the code.  More details to come.

I may hand this off to pkerr partway along.
(Assignee)

Updated

3 years ago
Summary: Update WebRTC code to webrtc.org stable branch 3.50 → Update WebRTC code to webrtc.org stable branch 40
I gave a try to jesup's current MQ on OpenBSD, and only had two small nits to fix:
- execinfo.h being inconditionally included and used in media/webrtc/trunk/webrtc/base/checks.cc. Worked around by adding && !defined(__OpenBSD__), currently testing a better solution (replacing __GLIBCXX__ by __GLIBC__)
- alloca.h being included wrongly in media/webrtc/trunk/webrtc/base/stringutils.h because the wrong BSD defined is tested. Worked around by including sys/param.h which defines BSD, currently testing a better solution (ie test for WEBRTC_BSD instead of BSD)

Will post a patch for those when my current build with "better" fixes succeeds.
Created attachment 8550677 [details] [diff] [review]
fixes-bsd

This cleaner patch also works for me.

Comment 3

3 years ago
Comment on attachment 8550677 [details] [diff] [review]
fixes-bsd

Review of attachment 8550677 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK given the lack of autodetecting stuff in upstream build system. Otherwise, cxxabi.h isn't specific to libstdc++ but also exists in compiler-rt or libexecinfo implements backtrace() for BSDs.
Attachment #8550677 - Flags: feedback+

Updated

3 years ago
Depends on: 1123012

Updated

3 years ago
Blocks: 1117034
(Assignee)

Comment 4

3 years ago
Created attachment 8556629 [details] [diff] [review]
Remove use of VoECallReport, as it's been removed
(Assignee)

Comment 5

3 years ago
Created attachment 8556630 [details] [diff] [review]
Adapt GMP video decoder code to API changes in webrtc.org 40
(Assignee)

Comment 6

3 years ago
Created attachment 8556631 [details] [diff] [review]
Make fake GMP codec test force fragmentation by returning large IDR frames
(Assignee)

Comment 7

3 years ago
Created attachment 8556632 [details] [diff] [review]
gyp changes to adapt to webrtc.org 40 update
(Assignee)

Comment 8

3 years ago
Created attachment 8556633 [details] [diff] [review]
Merge with webrtc.org update (android compile/merge fixes)
(Assignee)

Updated

3 years ago
Attachment #8550677 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8556629 - Flags: review?(pkerr)
(Assignee)

Updated

3 years ago
Attachment #8556630 - Flags: review?(ethanhugg)
(Assignee)

Updated

3 years ago
Attachment #8556631 - Flags: review?(ethanhugg)
(Assignee)

Updated

3 years ago
Attachment #8556632 - Flags: review?(ted)
(Assignee)

Comment 9

3 years ago
Green Try, with retriggers, after multistream landing
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d88e002dc1be
Attachment #8556632 - Flags: review?(ted) → review+
(Assignee)

Updated

3 years ago
Attachment #8556633 - Flags: review+

Updated

3 years ago
Attachment #8556629 - Flags: review?(pkerr) → review+

Comment 10

3 years ago
Comment on attachment 8556631 [details] [diff] [review]
Make fake GMP codec test force fragmentation by returning large IDR frames

Review of attachment 8556631 [details] [diff] [review]:
-----------------------------------------------------------------

r+ - couple nits.

::: dom/media/gmp-plugin/gmp-fake.cpp
@@ +165,5 @@
>      }
>  
>      // Now return the encoded data back to the parent.
>      GMPVideoFrame* ftmp;
> +    GMPErr err = host_->CreateFrame(kGMPEncodedVideoFrame, &ftmp);

This looks like a whitespace-only change, was it intended?

@@ +200,5 @@
>        return;
>      }
>      memcpy(f->Buffer(), &eframe, sizeof(eframe));
> +    if (frame_type  == kGMPKeyFrame) {
> +      *((uint32_t*) f->Buffer() + sizeof(eframe)) = 10000;

I would def this number since it is used twice.
Attachment #8556631 - Flags: review?(ethanhugg) → review+

Comment 11

3 years ago
Comment on attachment 8556630 [details] [diff] [review]
Adapt GMP video decoder code to API changes in webrtc.org 40

Review of attachment 8556630 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8556630 - Flags: review?(ethanhugg) → review+
(Assignee)

Comment 12

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a4769477bf
https://hg.mozilla.org/integration/mozilla-inbound/rev/55c60f012e8f
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4120c46b70
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ce90ec1773
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3ef5a28bc0f
https://hg.mozilla.org/integration/mozilla-inbound/rev/309a9690c49d
https://hg.mozilla.org/integration/mozilla-inbound/rev/44fc6711973e
https://hg.mozilla.org/integration/mozilla-inbound/rev/df17ce42df41
https://hg.mozilla.org/integration/mozilla-inbound/rev/984fb01e309d
https://hg.mozilla.org/integration/mozilla-inbound/rev/71c6989c93d7
https://hg.mozilla.org/integration/mozilla-inbound/rev/f46e138fb9dc
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a769d06f1bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/52762570ef98
https://hg.mozilla.org/integration/mozilla-inbound/rev/504a5ef25187
https://hg.mozilla.org/integration/mozilla-inbound/rev/37b8924b811e
https://hg.mozilla.org/integration/mozilla-inbound/rev/75201fc2e632
https://hg.mozilla.org/integration/mozilla-inbound/rev/7df2ed7e809c
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d971acefcf
https://hg.mozilla.org/integration/mozilla-inbound/rev/9150eca52844
https://hg.mozilla.org/mozilla-central/rev/f5a4769477bf
https://hg.mozilla.org/mozilla-central/rev/55c60f012e8f
https://hg.mozilla.org/mozilla-central/rev/aa4120c46b70
https://hg.mozilla.org/mozilla-central/rev/17ce90ec1773
https://hg.mozilla.org/mozilla-central/rev/c3ef5a28bc0f
https://hg.mozilla.org/mozilla-central/rev/309a9690c49d
https://hg.mozilla.org/mozilla-central/rev/44fc6711973e
https://hg.mozilla.org/mozilla-central/rev/df17ce42df41
https://hg.mozilla.org/mozilla-central/rev/984fb01e309d
https://hg.mozilla.org/mozilla-central/rev/71c6989c93d7
https://hg.mozilla.org/mozilla-central/rev/f46e138fb9dc
https://hg.mozilla.org/mozilla-central/rev/1a769d06f1bd
https://hg.mozilla.org/mozilla-central/rev/52762570ef98
https://hg.mozilla.org/mozilla-central/rev/504a5ef25187
https://hg.mozilla.org/mozilla-central/rev/37b8924b811e
https://hg.mozilla.org/mozilla-central/rev/75201fc2e632
https://hg.mozilla.org/mozilla-central/rev/7df2ed7e809c
https://hg.mozilla.org/mozilla-central/rev/c7d971acefcf
https://hg.mozilla.org/mozilla-central/rev/9150eca52844
https://hg.mozilla.org/mozilla-central/rev/35ef327737b6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: mozilla37 → mozilla38
Depends on: 1129858
Depends on: 1129921
Depends on: 1130223
(Assignee)

Updated

3 years ago
Blocks: 1132193
Depends on: 1134991

Updated

3 years ago
See Also: → bug 1137515

Updated

3 years ago
See Also: → bug 1140677
Blocks: 1109506
Blocks: 818631
You need to log in before you can comment on or make changes to this bug.