1135177 - Untangle project Target Memberships

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Our Target Memberships are a mess. As a quick example, trying to use ToolbarHeight (defined in BVC) in HomePanelViewController fails to build since HomePanelViewController is a member of ClientTests, whereas BVC is not.

Fixing this would require either adding BVC and all of its dependent files to the ClientTests target (not a good option), or removing HomePanelViewController and its parent dependencies from ClientTests. If we try to do the latter, we eventually get stuck because of the TestPanels -> Panels -> HistoryPanel -> HomePanelViewController dependency chain.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is not a target membership issue. What you see is a symptom of dependencies between code. It is normal and expected that multiple pieces of code that depends on eachother are part of the same target. If they were not then the target would not link.

I also think it is perfectly normal that all the sources in Client are also part of ClientTests; the latter contains tests for the former. So of course there is a dependency on that code.

Comment 2

[Brian Nicholson (:bnicholson)]

Sure, but I'd argue that ClientTests shouldn't be creating any dependencies on UI components since they aren't UI tests. When unit tests require you to import views and controllers, something in your dependency chain needs to be fixed.

(In reply to Stefan Arentz [:st3fan] from comment #1)
> This is not a target membership issue. What you see is a symptom of
> dependencies between code.

Yeah, that's all I was trying to say :)