Closed
Bug 1145335
Opened 10 years ago
Closed 10 years ago
Replace Storage project with Storage framework
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
Right now we can't have Storage depend on Shared or XCGLogger or ... because these things are not subprojects of the Storage project. What we want is a Storage framework in the Client project. This ticket tracks that work.
|
Assignee | |
Comment 1•10 years ago
|
||
Whoever can apply and test locally first, gents.
I tested that the browser and the StorageTests both work in the simulator and on the device.
Attachment #8580255 -
Flags: review?(sarentz)
Attachment #8580255 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8580255 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/240
rnewman reviewed on GH and IRC.
Attachment #8580255 -
Flags: review?(sarentz)
Attachment #8580255 -
Flags: review?(rnewman)
Attachment #8580255 -
Flags: review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
stefan: look here first if there are integration issues overnight.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(sarentz)
Resolution: --- → FIXED
|
||
Comment 5•10 years ago
|
||
Looks good to me. All builds are happy!
|
|
||
Updated•10 years ago
|
Flags: needinfo?(sarentz)
You need to log in
before you can comment on or make changes to this bug.
Description
•