Closed Bug 1145335 Opened 9 years ago Closed 9 years ago

Replace Storage project with Storage framework

Categories

(Firefox for iOS :: Build & Test, defect)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/240
47 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review 
Right now we can't have Storage depend on Shared or XCGLogger or ... because these things are not subprojects of the Storage project.  What we want is a Storage framework in the Client project.  This ticket tracks that work.
Whoever can apply and test locally first, gents.

I tested that the browser and the StorageTests both work in the simulator and on the device.
Attachment #8580255 - Flags: review?(sarentz)
Attachment #8580255 - Flags: review?(rnewman)
Comment on attachment 8580255 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/240

rnewman reviewed on GH and IRC.
Attachment #8580255 - Flags: review?(sarentz)
Attachment #8580255 - Flags: review?(rnewman)
Attachment #8580255 - Flags: review+
stefan: look here first if there are integration issues overnight.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(sarentz)
Resolution: --- → FIXED
Looks good to me. All builds are happy!
Flags: needinfo?(sarentz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: