Closed Bug 1135385 Opened 9 years ago Closed 9 years ago

Check out SwiftKeychainWrapper and json.swift using Carthage

Categories

(Firefox for iOS :: Build & Test, defect)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: nalexander, Assigned: nalexander, Mentored)

References

Details

Follow-up to Bug 1129158 and day 1, basically: we should check out more modules using Carthage.

Nota bene: the version of SwiftKeychainWrapper checked in to the tree is slightly changed from the one on github.  In particular, there's no objc in the tree version.  We'll need to upstream our changes or fork our own github repo.

This is a good mentor bug.
I tried adding dankogai/swift-json as a Carthage dependency in bug 1132795, but it failed since the swift-json repo doesn't tag versions. I think I might have also tried SwiftKeychainWrapper and had the same problem.
How about we fork these for now to one of our local repos where we can set a tag and ask the project owners to fix this.
(In reply to Stefan Arentz [:st3fan] from comment #2)
> How about we fork these for now to one of our local repos where we can set a
> tag and ask the project owners to fix this.

This is an expedient approach.  Worth noting that our version of SwiftKeychainWrapper is ahead of upstream.  I don't think I am an admin for github.com/mozilla, but I can work with somebody (rnewman? mfinkle? margaret?) to get this done.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
We've gone in a different direction and aren't bothering with Carthage for these.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.