1135681 - Use taskcluster client v0.0.9 in mozharness

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Michael Shal [:mshal]]

There are a number of improvements in the retry logic in the taskcluster client, so we should pull in the latest version before using the artifacts for testers. This should just involve updating the virtualenv_modules in mozharness.

Comment 1

[Michael Shal [:mshal]]

Attachment: taskcluster-0.0.9

Bump taskcluster to 0.0.9

I also added a temporary ignore-all-exceptions wrapper around upload_files. :jonasfj is re-writing some internal TC guts and doesn't want to break buildbot builds in the process. It will be backed out in bug 1135756 before we use these uploads for testers. Here's what the mozharness log looks like when I forced a ValueError in upload_files:

13:24:35  WARNING - Temporarily ignoring S3 upload exception:
13:24:35  WARNING - Traceback (most recent call last):
13:24:35  WARNING - 
13:24:35  WARNING -   File "/builds/slave/try-lx-00000000000000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1459, in postflight_build
13:24:35  WARNING -     self.upload_files()
13:24:35  WARNING - 
13:24:35  WARNING -   File "/builds/slave/try-lx-00000000000000000000000/scripts/mozharness/mozilla/building/buildbase.py", line 1268, in upload_files
13:24:35  WARNING -     raise ValueError('Testing error')
13:24:35  WARNING - 
13:24:35  WARNING - ValueError: Testing error
13:24:35  WARNING - 

The rest of the build proceeds as normal.

Comment 2

[Michael Shal [:mshal]]

Also FYI, taskcluster-0.0.9 is already in our pypi server.

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8568527 [details] [diff] [review]
taskcluster-0.0.9

Review of attachment 8568527 [details] [diff] [review]:
-----------------------------------------------------------------

how often will this fail? warning log lines will appear highlighted by treeherder in the summary of the build. If it's going to be every single job for a while, it might be a bit noisy for sheriffs and we should think about just s/warning/info instead. That is unless the reason/timing for failure is important and tc would like it highlighted.

Comment 4

[Michael Shal [:mshal]]

(In reply to Jordan Lund (:jlund) from comment #3)
> how often will this fail? warning log lines will appear highlighted by
> treeherder in the summary of the build. If it's going to be every single job
> for a while, it might be a bit noisy for sheriffs and we should think about
> just s/warning/info instead. That is unless the reason/timing for failure is
> important and tc would like it highlighted.

I think we do still want to have some indication if things aren't working properly, so that we can find and fix those issues. I don't really know how often we would expect it to fail - this is more of a precautionary thing in case the TC changes don't go as planned. Ideally it won't fail at all :). If it does end up being too noisy / annoying for sheriffs, switching to info sounds like a good plan.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8568527 [details] [diff] [review]
taskcluster-0.0.9

remote:   https://hg.mozilla.org/build/mozharness/rev/c31a34d8960c

Comment 6

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/c31a34d8960c

Comment 7

[Michael Shal [:mshal]]

Attachment: 0001-Bug-1135681-Bump-mozharness-rev.patch

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad7065d75643

Comment 8

[Michael Shal [:mshal]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2f718934413d

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f718934413d