Closed Bug 1135873 Opened 9 years ago Closed 9 years ago

Test Case - Add imagecompare video playback test case

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: njpark, Assigned: njpark)

Details

Attachments

(1 file)

[gaia] npark-mozilla:1135873 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
Details | Review 
This test would take the screenshot of the first frame and the last frame of the video playback window
Status: NEW → ASSIGNED
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

I made some changes to fullscreen_video.py in apps/videoplayer/regions as well
Attachment #8569418 - Flags: review?(martijn.martijn)
Attachment #8569418 - Flags: review?(dave.hunt)
Assignee: nobody → npark
Blocks: 1137273
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

A couple of nits/questions in the pull request.
Attachment #8569418 - Flags: review?(dave.hunt) → review-
Attachment #8569418 - Flags: review?(martijn.martijn) → review+
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

comments incorporated.
Attachment #8569418 - Flags: review- → review?(dave.hunt)
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

Sorry for not providing a more thorough initial review. I've added a few more comments.
Attachment #8569418 - Flags: review?(dave.hunt) → review-
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

no prob, I can always re-request for review :)
Attachment #8569418 - Flags: review- → review?(dave.hunt)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
oh crap, I didn't know autolander will merge with outstanding review request, apparently this only needs minimum one r+. let me know whether I should revert the checkin.  I should be extra careful next time
I think I should put keyword checkin-needed only AFTER i get reviews r+ed.
Comment on attachment 8569418 [details] [review]
[gaia] npark-mozilla:1135873 > mozilla-b2g:master

Yes, checkin-needed should only be added when the patch is ready to be checked in. I wouldn't worry about reverting this one, but take care when adding the keyword for future patches.
Attachment #8569418 - Flags: review?(dave.hunt)
No longer blocks: 1137273
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: