1136041 - [Text Selection] The carets overlap with utility bubble when the selected text is closed to top of device

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gerry Chang [:gchang]]

### Steps:
1. Open Browser app
2. Type any words in search bar, ex: "google map"
3. Select non-url characters in the page
4. Scroll up the screen until the selected word is closed to the top
5. Watch the positions of utility bubble and carets. The carets should be above of the utility bubble.

### Actual:
1. The carets and utility bubble overlap

### Expected:
1. The carets and utility bubble should not overlap

### Reproduce rate
always

### Version:
Gaia-Rev        389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/81bcdde1e783
Build-ID        20150223162505
Version         37.0
Device-Name     flame
FW-Release      4.4.2

Comment 1

[Gerry Chang [:gchang]]

NI UX to see if the utility bubble should overlap carets (because the water drop becomes larger).

Comment 2

[Gerry Chang [:gchang]]

Attachment: BZ1136041.png

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

@George, please move the bubble a little bit downward, thanks!

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:1136041 > mozilla-b2g:master

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8569646 [details] [review]
[gaia] cctuan:1136041 > mozilla-b2g:master

Hi Alive,
since caret's size has been enlarged, we need to change the position of bubble. And vd also request to have a margin between screen's boundary and bubble.

Please kindly check, thanks.

Comment 6

[howie [:howie]]

Triage: blocking 2.2

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, 
https://github.com/mozilla-b2g/gaia/commit/ef6a7b7a9a3d2b4305c7d798481ccdbc99e09ac8

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8569646 [details] [review]
[gaia] cctuan:1136041 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression nor a feature of gaia.
[User impact] if declined: Bubble might overlap the caret and cause bad user experience.
[Testing completed]: Yes. visual team has checked and also updated the unit test.
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f88e7c56a10613ee41e2e83e1ff4bb7a4f954318

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the lates Nightly Flame 3.0 and 2.2 builds.

Actual Results: When text near the top of the screen is selected, the selection carats do not overlap with the copy paste icons.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150311110236
Gaia: 2b87ee8e7e2ec30a9851b6b59a899006a98767ab
Gecko: bc6aeea72290
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150311002522
Gaia: 3f032238a52f08e4c2f68a47ad065a96eb22d470
Gecko: 004fa1cb1dd4
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0