1136123 - Can't go back from Operator services

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Pre-requisites
Have a SIM card which provides operator services

STR
1. Go to the bottom of settings and open the operator services
2. Tap the back button.

Actual results
Taping on the back arrow doesn't do anything, except blinking.

Build info
Build ID               20150224010314
Gaia Revision          31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gaia Date              2015-02-23 15:25:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/368c62292249
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150224.050300
Firmware Date          Tue Feb 24 05:03:10 EST 2015
Bootloader             L1TC000118D0

Doesn't repro on 2.1:
Build ID               20150220001208
Gaia Revision          373df4bec2c20228f45be0b24111252171f925e9
Gaia Date              2015-02-19 13:52:34
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/10c100cba54d
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20141120.194707
Firmware Date          Thu Nov 20 19:47:17 EST 2014
Bootloader             L1TC00011880

Comment 1

[Johan Lorenzo [:jlorenzo]]

QA wanted to check if it can be reproduced with an AT&T or a T-Mobile SIM card. If it does, please proceed to a branch check and get a logcat with RIL debugging enabled[1]

[1] https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#RIL_Debugging

Comment 2

[Yeojin Chung [:YeojinC]]

This issue is not reproducible with an AT&T or a T-Mobile SIM. However, I was able to reproduce this issue with a roaming SIM on Flame Master and 2.2.

Result: The back button does not work on the Operator Services screens.

Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20150224_BackButtonNotWorking.txt

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

This seems pretty bad so I am requesting a regression window here.

Comment 5

[Yeojin Chung [:YeojinC]]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150211214241
Gaia: 561b7459f1c880947127519e72cc3d0ccf4de69b
Gecko: 70cb72ac6f4d
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150211230751
Gaia: 346df113f953e8baef04c7cca86cbbd03ae55ab3
Gecko: aa06a546c23b
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: 561b7459f1c880947127519e72cc3d0ccf4de69b
Gecko: aa06a546c23b 

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 346df113f953e8baef04c7cca86cbbd03ae55ab3
Gecko: 70cb72ac6f4d 

https://github.com/mozilla-b2g/gaia/compare/561b7459f1c880947127519e72cc3d0ccf4de69b...346df113f953e8baef04c7cca86cbbd03ae55ab3

caused by bug 1130965

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Arthur, can you take a look at this please? This might have been caused by the work done for bug 1130965.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

It seems I broke the function when did the final polish to the patch... Will provide a patch fixing it soon.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1136123 > mozilla-b2g:master

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8568927 [details] [review]
[gaia] crh0716:1136123 > mozilla-b2g:master

Evelyn, would you mind take a look at this patch? It has nothing to do with the STK things but only fixes the way of registering handlers. Let me know if any problems, thanks!

Comment 11

[Evelyn Hung]

Comment on attachment 8568927 [details] [review]
[gaia] crh0716:1136123 > mozilla-b2g:master

Looks good. Thanks!

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, Evelyn!

master: a1f9b818e12bcde82775c28a328561df00e86741

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8568927 [details] [review]
[gaia] crh0716:1136123 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1130965
[User impact] if declined: Users are not able to back from the operator services.
[Testing completed]: Testing on the device.
[Risk to taking this patch] (and alternatives if risky): Low as it fixes an unintended mistake.
[String changes made]: None

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5e0b7649a32ef115adb56c7ba2ed297402e91cae

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Flame v2.2&3.0. 
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5.

STR:
1.Insert a USIM card(or two SIM cards).
2.Go to the bottom of Settings and open the operator services.
3.Tap the "<" button. 
**The "<" buttion works normally,and user can go back from Operator services.

Flame 2.2 build:
Build ID               20150308002503
Gaia Revision          166491b92278dc9e648f8d49ab02d9ca00d74421
Gaia Date              2015-03-06 18:26:27
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a48af0b5a6e4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150308.052515
Firmware Date          Sun Mar  8 05:25:25 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build:
Build ID               20150308160204
Gaia Revision          fea83511df9ccba64259346bc02ebf2c417a12c2
Gaia Date              2015-03-08 06:36:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eab4a81e4457
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150308.192120
Firmware Date          Sun Mar  8 19:21:31 EDT 2015
Bootloader             L1TC000118D0

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4