1136165 - Uplift EME UI patches to 37 beta to increase testing population

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

(I'm assuming this is confidential per previous email discussions, if not, please open up immediately)

So I was hoping to get patches ready, except it seems like most of the backend stuff (specifically at least bug 1124491 and bug 1111160) haven't landed either, and so neither the context menu nor the notifications would actually work... I tried generating uplift patches myself, but at least 1111160 doesn't apply at all cleanly on current 37 beta. Chris, can you look at this?

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Release management want to see the launch partner's site working with Adobe EME working in Nightly before approving platform uplifts, and currently Adobe's CDM doesn't work and the launch partner have no CDM to test against so uplifting the platform bits in time for a week of runtime in a beta cycle before we have to pref it off seems overly optimistic. Adobe are at a summit this week, so nothing will happen on their end this week. We're meeting with Adobe and the launch partner on Monday PDT to discuss whether its possible. My guess is that we're not going to make the window for testing in beta 37.

Comment 2

[Justin Dolske [:Dolske]]

To be clear: there is significant risk that we won't be able to get user testing in 37-Beta (due to partner work being behind schedule), but we _do_ want to proceed with getting patches uplifted to 37. So that work should proceed.

I assume 1111160 will apply to 37 one Chris finished preparing his ~50-patch EME/MSE uplift.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yes. Bug 1111160 should apply, or at least be trivially unbitrotable once I'm done uplifting.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I am tracking uplift of platform pieces in bug 1137045.

Comment 5

[:Gijs (he/him)]

Attachment: MozReview Request: bz://1136165/Gijs

/r/4555 - Bug 1111146 - [EME] Implement master pref for playing DRM content, including pref. r=gijs,dao
/r/4557 - Bug 1127288 - add header for DRM checkbox, fix link alignment, r=dolske
/r/4559 - Bug 1111147 - update nsContextMenu for EME, r=florian
/r/4561 - Bug 1111148 - show doorhanger for EME being played back, r=florian
/r/4563 - Bug 1111153 - show error notifications for broken EME content (includes fix for bug 1139022), r=florian
/r/4565 - Bug 1131758 - indicate 64-bit windows or OSX/Linux incompatibilities for Adobe's CDM, r=dolske
/r/4567 - Bug 1135237 - update message for EME notification, r=dolske

Pull down these commits:

hg pull review -r 67cb9c08b70c0def672e11939dff0a17f86c6880

Comment 6

[:Gijs (he/him)]

Comment on attachment 8572105 [details]
MozReview Request: bz://1136165/Gijs

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: No UI for EME when we try it out on beta
[Describe test coverage new/current, TreeHerder]: nope. :-(
[Risks and why]: reasonably low, disabled by default and will only be used for beta testing with partners
[String/UUID change made/needed]: moved all the strings to either be inline or in a content-side properties file, and verified with Axel that that's OK for l10n.

Comment 7

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f41e211302 has everything except the last commit, which I'd fix except try is closed...

Comment 8

[Justin Dolske [:Dolske]]

Comment on attachment 8572105 [details]
MozReview Request: bz://1136165/Gijs

rs=me, I didn't look deeply at this since it's just hard-coding strings from previous work.

Comment 9

[:Gijs (he/him)]

Ploink.

remote:   https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=0e44d113855f

Comment 10

[Justin Dolske [:Dolske]]

\o/ Thanks.

Comment 12

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1111146 - [EME] Implement master pref for playing DRM content, including pref. r=gijs,dao

Comment 13

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1127288 - add header for DRM checkbox, fix link alignment, r=dolske

Comment 14

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1111147 - update nsContextMenu for EME, r=florian

Comment 15

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1111148 - show doorhanger for EME being played back, r=florian

Comment 16

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1111153 - show error notifications for broken EME content (includes fix for bug 1139022), r=florian

Comment 17

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1131758 - indicate 64-bit windows or OSX/Linux incompatibilities for Adobe's CDM, r=dolske

Comment 18

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1135237 - update message for EME notification, r=dolske