1136218 - Make sure we use NSLocalizedString() everywhere

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Scan through the code to find out if we use NSLocalizedString() for text elements.

Comment 1

[Jeff Beatty [:gueroJeff]]

Attachment: Screenshots of unlocalizable strings

I localized the exported xliff file to 100% completion and imported the strings into xcode with no import errors. I also adjusted the runtime settings to run the os simulator and app in the appropriate locale (es-MX), as well as to call out strings that are unlocalizable. These screenshots are of strings that are not available in the xliff export for localization.

In addition, the fx accounts page does not present the fx accounts page in the appropriate locale.

Comment 2

[Jeff Beatty [:gueroJeff]]

Just wanted to check in on how we're doing on this. I saw that there was a good sized update this last week in the number of strings so I assume it's going well.

Comment 3

[Francesco Lodolo [:flod]]

See bug 1144338 comment 4 (forgot about this one). The "Boorkmark" button doesn't have a localizable accessibility string associated.

> It seems indeed not localizable (from what I understand of Swift code, which
> is very little)
> https://github.com/mozilla/firefox-ios/blob/
> 46647ae016374c1a8a6a68ea0f818741a005191e/Client/Frontend/Browser/
> BrowserToolbar.swift#L58-L61
> 
> Please also add a note that it's a verb, not a noun, as in "Add to bookmark".

Comment 4

[Richard Newman [:rnewman]]

Here's a list as of Right Now:

https://gist.github.com/rnewman/5d5e6a30558743d0cde7

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8589374 [details] [review]
Pull request

LGTM. Some comments on the PR.