Closed Bug 1136218 Opened 9 years ago Closed 9 years ago

Make sure we use NSLocalizedString() everywhere

Categories

(Firefox for iOS :: General, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: st3fan, Assigned: bnicholson)

References

Details

Attachments

(2 files)

Scan through the code to find out if we use NSLocalizedString() for text elements.
I localized the exported xliff file to 100% completion and imported the strings into xcode with no import errors. I also adjusted the runtime settings to run the os simulator and app in the appropriate locale (es-MX), as well as to call out strings that are unlocalizable. These screenshots are of strings that are not available in the xliff export for localization.

In addition, the fx accounts page does not present the fx accounts page in the appropriate locale.
Just wanted to check in on how we're doing on this. I saw that there was a good sized update this last week in the number of strings so I assume it's going well.
See bug 1144338 comment 4 (forgot about this one). The "Boorkmark" button doesn't have a localizable accessibility string associated.

> It seems indeed not localizable (from what I understand of Swift code, which
> is very little)
> https://github.com/mozilla/firefox-ios/blob/
> 46647ae016374c1a8a6a68ea0f818741a005191e/Client/Frontend/Browser/
> BrowserToolbar.swift#L58-L61
> 
> Please also add a note that it's a verb, not a noun, as in "Add to bookmark".
Status: NEW → ASSIGNED
tracking-fennec: --- → +
OS: Mac OS X → iOS 8
Hardware: x86 → All
Attached file Pull request
Assignee: sarentz → bnicholson
Attachment #8589374 - Flags: review?(rnewman)
Comment on attachment 8589374 [details] [review]
Pull request

LGTM. Some comments on the PR.
Attachment #8589374 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: