1136286 - [Settings][Privacy Controls] There is no way to "x" out of the Guided Tour on a few pages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Guided Tour Logcat

Description:
During the Guided Tour of the Privacy controls, there is seemingly random pages that are missing an "x" in the upper left corner, in order to dismiss the tour


Repro Steps:
1) Update a Flame to 20150224010314
2) Open Settings App> Privacy Controls
3) If the Guided Tour does not start, open the Guided Tour
4) Tap Get Started!> Tap "Next" 5 times, and observe top left corner


Actual:
There is no X on this page to dismiss the Guided tour. This also occurs on the 9th and 10th page of the Tour


Expected:
There is consistency in the Guided Tour, so there is either always a way to dismiss the tour, or no way to dismiss the tour until the end

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 10/10
See attached: Logcat, Video - http://youtu.be/51U1ZDr9oTc

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2

There is no X on this page to dismiss the Guided tour.

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
________________________________________________________________________________________

The Privacy controls did not exist in Flame 2.1

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat)(Full Flash)
Build ID: 20150224002520
Gaia: 86af0ca427adad12c3109124f31bef2fd9614e47
Gecko: a275f2c05ca6
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 3

[Gerry Chang [:gchang]]

Hi Marta,
This might need your help.

Comment 4

[marta]

I will look at it

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] martasect:Bug_1136286 > mozilla-b2g:master

Comment 6

[marta]

Comment on attachment 8571025 [details] [review]
[gaia] martasect:Bug_1136286 > mozilla-b2g:master

Could you review?

Comment 7

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Comment on attachment 8571025 [details] [review]
[gaia] martasect:Bug_1136286 > mozilla-b2g:master

This patch has fixed the issue on Flame 3.0

After uploading the patch to my device, there is an "x" on each page so the user can dismiss the guided tour at any point. 

Environmental Variables:
Device: Flame 3.0
Build ID: 20150302010223
Gaia: d2242b274968ac4188c0feae513e74557f2b0f9a
Gecko: eea6188b9b05
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[marta]

What do I do here?

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8571025 [details] [review]
[gaia] martasect:Bug_1136286 > mozilla-b2g:master

Hmm, I'm not sure if the request of Derek was meant as a technical review of the code? In any case, we probably want to setup a proper component for privacy panel work, but for now I will leave my review and manually land this as it looks simple enough. Thanks!

Comment 11

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/0c4e8b0b330757e261b031b7e7f326ef419c9808

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 build.  Setting the verifyme tag so this gets checked if/when 2.2 gets fixed.

Actual Results: All pages of the Guided Tour had the 'x' button available.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150312010235
Gaia: 0c4e8b0b330757e261b031b7e7f326ef419c9808
Gecko: 5334d2bead3e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 on this when you get a chance.

Comment 14

[marta]

Comment on attachment 8571025 [details] [review]
[gaia] martasect:Bug_1136286 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Bug 1136286
[User impact] if declined: During the Guided Tour of the Privacy controls, there is seemingly random pages that are missing an "x" in the upper left corner, in order to dismiss the tour - user will not be able to exit the GT. 
[Testing completed]: YES
[Risk to taking this patch] (and alternatives if risky): low

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/4d908bbb04c9a4af742161f38073cf5fcd36e708

Comment 16

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame 2.2
STR:
1. Open Settings App> Privacy Controls.
2. If the Guided Tour does not start, open the Guided Tour.
3. Tap Get Started!> Tap "Next" button, and observe top left corner
**All pages of the Guided Tour had the 'x' button available.
See attachment:verify_video.MP4
Rate:0/5

Device: Flame 2.2(pass)
Build ID               20150323162503
Gaia Revision          e54c4ed1cc188f70ddf1156534d364005dc45490
Gaia Date              2015-03-23 19:09:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7ba1778d237b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150323.200543
Firmware Date          Mon Mar 23 20:05:54 EDT 2015
Bootloader             L1TC000118D0