54.74 KB, image/png
46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
55.16 KB, image/png
54.08 KB, image/png
Created attachment 8568709 [details] negative.png Description: In Privacy Control, you can set a custom location for apps to 'detect' you at. The custom location can be set by entering a region / city OR by entering GPS coordinates. The default Longitude coordinate begins with a negative sign. When the device is set to RTL, this negative flips to the right side of the number which is incorrect. Repro Steps: 1) Update a Flame to 20150224010314 2) Launch Settings 3) Set device to Arabic 4) Launch Privacy Controls 5) Select Location Accuracy 6) Flip the slider to allow Location adjustment and set a custom location 7) Scroll down to GPS coordinates Actual: negative sign is flipped to the right side of the number Expected: negative sign will remain on the left side of numbers / coordinates Environmental Variables: Device: Flame Master Build ID: 20150224010314 Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e Gecko: 368c62292249 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Repro frequency: 4/4 See attached: screenshot
This issue also occurs on 2.2 Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem) Build ID: 20150224002637 Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5 Gecko: 2b70d9d62799 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0 (Master) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Is this just an incorrect presentation or does it also prevent the feature from working?
ni to Peter too, looking for an answer to comment 2.
It seems to be just an incorrect presentation. Test Method: I first set the device to English and set my custom location to GPS -22.903371 -43.209580 (Rio De Janeiro). I then checked google maps and the geolocation was correct. I then switched language to Arabic (RTL) and verified the lat / long did swap the - to the right side of he number. I then checked Yahoo maps and Google maps again and both properly showed my location as Rio De Janeiro. So it seems to not actually affect the functionality
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15731/
Blocking because this is silly to ship with and could be a quick fix, but I don;t know if this is a privacy or geo-location so Ni'ing garvan first to look at it
My area is deeper in the guts of gecko geolocation, which just passes lat/longs up through the system. If you can find out who did the Gaia code on that screen, I think they'll be able to fix the numeric display for RTL.
See if Marta can help, thanks.
Assign Marta for this one, thanks.
hey Gandalf and Stas: can you take a look into this or point to someone else? this is an RTL issue so not Privacy Panel per say thanks!
(clearing off the ni for Marta)
I am changing it to non-Privacy Controls related bug, and releasing it.
(In reply to Delphine Lebédel [:delphine - use need info] from comment #10) > hey Gandalf and Stas: can you take a look into this or point to someone > else? this is an RTL issue so not Privacy Panel per say I think this isn't a bug. As far as I can tell, this is how it's supposed to look like in RTL languages. The minus sign should go *before* the number, which in RTL means to the right. Also, how was this screenshot taken? This isn't Arabic nor the Mirrored English pseudolocale.
Stas: spoke with Ahmed offline for a double confirmation. He confirms this is a bug: numbers read LTR in Arabic, - sign should be on left :) thanks!
Created attachment 8580570 [details] [review] [gaia] stasm:1136321-negative-rtl > mozilla-b2g:master
OK, I think I got confused by the mathematical notation of Western Arabic numbers vs. Easter Arabic. Thanks for checking with Ahmed, Delphine!
Comment on attachment 8580570 [details] [review] [gaia] stasm:1136321-negative-rtl > mozilla-b2g:master Marta, can you take a look at this?
Comment on attachment 8580570 [details] [review] [gaia] stasm:1136321-negative-rtl > mozilla-b2g:master looks simple and good.
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Manually landing this for now. There's no try run, but I'm fairly confident that this will pass given that it's only simple HTML changes. https://github.com/mozilla-b2g/gaia/commit/8712ff718817f647a40d021ac1c9495ada21f51f
Created attachment 8582835 [details] verify_v3.0.png This issue has been verified successfully on latest build of Flame 3.0 with the same steps in comment 0. The negative symbol(-) remains on the left side of numbers / coordinates. See attachment:verify_v3.0.png Rate:0/5 Device: Flame 3.0(pass) Build ID 20150324160206 Gaia Revision aebfbd998041e960cea0468533c0b5041b504850 Gaia Date 2015-03-24 17:08:51 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/264387e7e453 Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150324.193523 Firmware Date Tue Mar 24 19:35:34 EDT 2015 Bootloader L1TC000118D0
Please request Gaia v2.2 approval on this patch when you get a chance.
Comment on attachment 8580570 [details] [review] [gaia] stasm:1136321-negative-rtl > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: negative lat/lon values will look incorrect in RTL languages [Testing completed]: on the device [Risk to taking this patch] (and alternatives if risky): very low [String changes made]: none
Created attachment 8587110 [details] v2.2_verify.png This issue has been verified successfully on latest build of Flame 2.2 with the same steps in comment 0. The negative symbol(-) remains on the left side of numbers / coordinates. See attachment:v2.2_verify.png Rate:0/5 Device: Flame 2.2 (pass) Build ID 20150401002624 Gaia Revision 8b3086ad3963f1707e2bee9094baccafffe161c4 Gaia Date 2015-03-31 21:48:06 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20b67213a047 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150401.042225 Firmware Date Wed Apr 1 04:22:36 EDT 2015 Bootloader L1TC000118D0