1136326 - Style the LDAP info page in address book

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 170270 introduced in address book, when a LDAP AB is selected, a info page to inform there are only results shown when searched.

This bug is to style this page like the trees.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: LDAPBlankPage.patch

Use -moz-field as background color and hide the splitter below.

Comment 2

[Thomas D. (:thomas8)]

Screenshot of current patch would be nice

Comment 3

[Richard Marti (:Paenglab)]

There is no need for a screenshot. The patch gives this box only the same background color as the tree has. It looks then as the tree is empty with one centered message. On OS X and XP the splitter are thick and it is looking weird to show them below the message box without a function, so I hide them. On Linux and Win7+ the splitter is small but it's also better to hide them.

Comment 4

[Thomas D. (:thomas8)]

(In reply to Richard Marti (:Paenglab) from comment #3)
> There is no need for a screenshot. The patch gives this box only the same
> background color as the tree has.

Ok, thanks, sounds good. The tree on the left or on the right?

Comment 5

[Richard Marti (:Paenglab)]

On the right.

Comment 6

[Josiah Bruner [:jsbruner]]

Comment on attachment 8568727 [details] [diff] [review]
LDAPBlankPage.patch

Review of attachment 8568727 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have an LDAP address book, but the code looks fine. Assuming you have tested this on all three platforms, r+.

If not, please verify the results!

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed as https://hg.mozilla.org/comm-central/rev/a27f018cf6eb

Comment 8

[Kent James (:rkent)]

TB 38?

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 8568727 [details] [diff] [review]
LDAPBlankPage.patch

[Approval Request Comment]
Regression caused by (bug #): Not a regression but a new feature by bug 170270
User impact if declined: Wrong background color of message
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): Low, only css change.

Comment 10

[Kent James (:rkent)]

Comment on attachment 8568727 [details] [diff] [review]
LDAPBlankPage.patch

Pushed as https://hg.mozilla.org/releases/comm-aurora/rev/0d48ec44636b