1136359 - Backout Array.includes and String.includes usage in tab completion code

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

Bug 1134905 contained https://hg.mozilla.org/comm-central/rev/56cf0d1ed0a0, which switched to using Array.includes and String.includes. Both of these are however only enabled in nightlies at present, so we need to back it out from both TB and IB.

Comment 1

[aleth [:aleth]]

Attachment: noindexof-backout.diff

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8568776 [details] [diff] [review]
noindexof-backout.diff

Review of attachment 8568776 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for asking you to change it!

::: im/content/conversation.xml
@@ -1051,5 @@
>              // Keep only the completions that share |word| as a prefix.
>              // Be case insensitive only if |word| is entirely lower case.
>              let condition;
>              if (word.toLocaleLowerCase() == word)
> -              condition = c => c.toLocaleLowerCase().startsWith(word);

startsWith landed a few versions ago, I believe.

Comment 3

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> Comment on attachment 8568776 [details] [diff] [review]
> noindexof-backout.diff
> 
> Review of attachment 8568776 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry for asking you to change it!
> startsWith landed a few versions ago, I believe.

That's true, but it's cleaner to back out the whole patch imho.

Comment 4

[aleth [:aleth]]

Attachment: noindexof-backout.diff 2

You can pry my startsWith from my cold, dead hands, etc.

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2

Thanks! :)

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/e3d29a059ddf

Comment 7

[aleth [:aleth]]

Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2

[Approval Request Comment]
Regression caused by (bug #): Bug 1134905
User impact if declined: tab completion failures
Risk to taking this patch (and alternatives if risky): none, this is a backout.

Comment 8

[Kent James (:rkent)]

Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2

https://hg.mozilla.org/releases/comm-aurora/rev/4880a53c711b

Comment 9

[aleth [:aleth]]

(In reply to Kent James (:rkent) from comment #8)
> https://hg.mozilla.org/releases/comm-aurora/rev/4880a53c711b

Thanks!