1136404 - Remove Puppet at boot for Windows EC2 instances

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Mark Cornmesser [:markco]]

A mechanism will need to be in place to remove the Puppet at boot schedule tasks for Windows EC2 instances that are based off of the golden image.

Comment 1

[Mark Cornmesser [:markco]]

Attachment: BUG1136404-2.patch

Comment 2

[Mark Cornmesser [:markco]]

Attachment: BUG1136404-2.patch

Comment 3

[Mark Cornmesser [:markco]]

This 2 part. First the aws user data will have this after the Puppet run:

:RM_SCH_TASK
schtasks /delete /TN RUNPUPPET

Then the attached patch removes the checks that would not allow buildbot to start.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8584163 [details] [diff] [review]
BUG1136404-2.patch

Review of attachment 8584163 [details] [diff] [review]:
-----------------------------------------------------------------

This will make things a little tricky when we *also* want to configure onsite hosts that do keep running Puppet.

Is it possible to replace the puppet run script, or add a conditional to it, so that it just pretends to run puppet (and sets the semaphore)?

Comment 5

[Mark Cornmesser [:markco]]

We have a separate scripts based on if the machine is in AWS or not: 
http://hg.mozilla.org/build/puppet/file/1c285f744720/modules/buildslave/manifests/startup/windows.pp

    11     # Batch file to start buildbot

    12     # Batch files varies slightly between AWS and datacenter machines 

    13     case $::fqdn {

    14         /.*\.releng\.(use1|usw2)\.mozilla\.com$/: {

    15             include instance_metadata

    16             file {

    17                 'c:/programdata/puppetagain/start-buildbot.bat':

    18                     content  => template("${module_name}/EC2_start-buildbot.bat.erb"),

    19                     require  => Class[instance_metadata];

    20             }

    21         }

    22         default: {

    23             file {

    24                 'c:/programdata/puppetagain/start-buildbot.bat':

    25                     content  => template("${module_name}/start-buildbot.bat.erb");

    26             }

    27         }

    28     }

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8584163 [details] [diff] [review]
BUG1136404-2.patch

Ah, perfect, thanks for the reminder!

Comment 7

[Mark Cornmesser [:markco]]

Comment on attachment 8584163 [details] [diff] [review]
BUG1136404-2.patch

Review of attachment 8584163 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/puppet/rev/7eb37cc224db