1136494 - WebGL 1.0.3 conformance/renderbuffers/feedback-loop.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Luke]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150224030228

Steps to reproduce:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/renderbuffers/feedback-loop.html?webglVersion=1


Actual results:

conformance/renderbuffers/feedback-loop.html (7 of 9 passed)

    failed: getError expected: INVALID_OPERATION. Was NO_ERROR : after draw with invalid feedback loop
    failed: at (0, 0) expected: 0,0,255,255 was 0,255,0,255


Expected results:

Chrome passes all the tests. Firefox fails with both the ANGLE and OpenGL backends.

Comment 1

[Petruta Horea [:phorea], Desktop QA]

Environment: Win 7 64-bit
Reproduced with Nightly 39.0a1 2015-02-25 (2 fails); no fails using Google Chrome Version 40.0.2214.115 m.

Comment 2

[Jukka Jylänki]

This is most likely fixed when https://bugzilla.mozilla.org/show_bug.cgi?id=936739 is implemented(?)

Comment 3

[Jukka Jylänki]

This test was reproduced to fail on the following tested devices:
 - SPARK, GIADA, MACBOOK_AIR_OSX, MACBOOK_AIR_WIN, MACBOOK_PRO_OSX, MACBOOK_PRO_WIN, MACMINI, MACPRO, NEXUS-4, NEXUS-5, NEXUS-10, SURFACE, WINDBOX, HPOMEN

See https://bugzilla.mozilla.org/show_bug.cgi?id=1178601 for hardware configuration details of these systems.

Comment 4

[Ethan Lin[:ethlin]]

I will study this.

Comment 5

[Jukka Jylänki]

Retested this today on my HASWELL PC with

Windows 10 Home 64-bit
3.0 GHz Intel 8-Core i7-5960X
32GB of RAM
3840x2160 pixels display

SLI 2x ASUS NVIDIA GeForce GTX 980 Ti, 4+4GB of VRAM, driver version 365.19
	- nvd3dumx.dll, nvwgf2umx.dll:
		- version 10.18.13.6191
		- date 2/8/2016
		- D3D Version 12.1, WDDM 2.0, WHQL approved

with Firefox Nightly 50.0a1 (2016-06-19), and I see the failure still occurs.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Try to pull <windows.h> include out of GLContext.h. -

Review commit: https://reviewboard.mozilla.org/r/64320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64320/

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Update LinkInfo. -

Review commit: https://reviewboard.mozilla.org/r/64322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64322/

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Update post-link validation. -

Review commit: https://reviewboard.mozilla.org/r/64324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64324/

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Add WebGLTexture::IsFeedback. -

Review commit: https://reviewboard.mozilla.org/r/64326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64326/

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Update uniform setters. -

Review commit: https://reviewboard.mozilla.org/r/64328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64328/

Comment 11

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Validate mActiveProgramLinkInfo in ScopedResolveTexturesForDraw, since it's run first. -

Review commit: https://reviewboard.mozilla.org/r/64330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64330/

Comment 12

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1136494 - Update test markings.

Review commit: https://reviewboard.mozilla.org/r/64332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64332/

Comment 13

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771058 [details]
Bug 1136494 - Try to pull <windows.h> include out of GLContext.h. -

https://reviewboard.mozilla.org/r/64320/#review61478

Comment 14

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771059 [details]
Bug 1136494 - Update LinkInfo. -

https://reviewboard.mozilla.org/r/64322/#review61514

::: dom/canvas/WebGLProgram.cpp:119
(Diff revision 1)
> -    activeInfoList->push_back(info);
> +    }
>  }
>  
> -//#define DUMP_SHADERVAR_MAPPINGS
> +//////////
> +
> +#define DUMP_SHADERVAR_MAPPINGS

Do we need turn on this debug flag?

Comment 15

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771060 [details]
Bug 1136494 - Update post-link validation. -

https://reviewboard.mozilla.org/r/64324/#review61522

Comment 16

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771061 [details]
Bug 1136494 - Add WebGLTexture::IsFeedback. -

https://reviewboard.mozilla.org/r/64326/#review61534

Comment 17

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771063 [details]
Bug 1136494 - Validate mActiveProgramLinkInfo in ScopedResolveTexturesForDraw, since it's run first. -

https://reviewboard.mozilla.org/r/64330/#review61536

Comment 18

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8771062 [details]
Bug 1136494 - Update uniform setters. -

https://reviewboard.mozilla.org/r/64328/#review61560

Great!

Comment 19

[Kelsey Gilbert [:jgilbert]]

https://reviewboard.mozilla.org/r/64322/#review61514

> Do we need turn on this debug flag?

Nope.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c35da4f57e6
Try to pull <windows.h> include out of GLContext.h. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/b78045c38ca2
Update LinkInfo. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a13fc6c82c4
Update post-link validation. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/be7d2dd9f84f
Add WebGLTexture::IsFeedback. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/d13fc4592665
Update uniform setters. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/34b7d622c520
Validate mActiveProgramLinkInfo in ScopedResolveTexturesForDraw, since it's run first. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/37a5b78f9a9d
Update test markings.

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c35da4f57e6
https://hg.mozilla.org/mozilla-central/rev/b78045c38ca2
https://hg.mozilla.org/mozilla-central/rev/5a13fc6c82c4
https://hg.mozilla.org/mozilla-central/rev/be7d2dd9f84f
https://hg.mozilla.org/mozilla-central/rev/d13fc4592665
https://hg.mozilla.org/mozilla-central/rev/34b7d622c520
https://hg.mozilla.org/mozilla-central/rev/37a5b78f9a9d