Closed Bug 1136526 Opened 5 years ago Closed 5 years ago

Replace silhouetted versions of Firefox logo with unbranded logo

Categories

(Firefox :: General, defect)

35 Branch
defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox40 --- verified

People

(Reporter: Unfocused, Assigned: jaws, Mentored)

References

Details

(Whiteboard: [bugday-20150812])

Attachments

(3 files)

Bug 1073240 added some images for use in the about:customizing theme selector and for the default theme icon in the Add-ons Manager:

https://hg.mozilla.org/mozilla-central/raw-file/f430ec9c5e3f/browser/themes/shared/icon.png
https://hg.mozilla.org/mozilla-central/raw-file/f430ec9c5e3f/browser/themes/linux/theme-switcher-icon.png
https://hg.mozilla.org/mozilla-central/raw-file/f430ec9c5e3f/browser/themes/osx/theme-switcher-icon.png
https://hg.mozilla.org/mozilla-central/raw-file/f430ec9c5e3f/browser/themes/windows/theme-switcher-icon.png
https://hg.mozilla.org/mozilla-central/raw-file/f430ec9c5e3f/browser/themes/windows/theme-switcher-icon-aero.png

These are silhouetted versions of the Firefox logo, which means they're covered under trademark. As such, they need to not be part of the build unless --official-branding is enabled. If that isn't enabled, we need to use images that do not contain a version of the Firefox logo.

So those images need moved into /browser/branding/official

I suggest that we add images to the other branding options in browser/branding, using a similar silhouetted version of the relevant logo.

While we're at it, we should do an inventory to ensure there are no other such images in the tree that are similarly affected.
Flags: qe-verify-
Flags: firefox-backlog+
Michael or Stephen, do we have an unbranded silhouetted logo that can be used when branding is disabled?
Flags: needinfo?(shorlander)
Flags: needinfo?(mmaslaney)
Alternatively if we don't, we could just take the "unbranded" logo and make a resized copy that fits the same size as the silhouetted logo and just use that for unbranded builds.
Assignee: nobody → abhinav.koppula
Mentor: jaws
Status: NEW → ASSIGNED
Abhinav, any update on this?
Flags: needinfo?(abhinav.koppula)
I talked with Stephen today and he thinks we should just use the unbranded logo that he attached to the bug in place of the Firefox silhouetted logo. So this bug is a lot simpler now. The file for the branded logo should just be replaced with this new attachment.
Summary: Move silhouetted versions of Firefox logo into browser/branding → Replace silhouetted versions of Firefox logo with unbranded logo
Stephen, can you also provide the "aero" version and the 2x version(theme-switcher-icon@2x) of the unbranded logo?
Also, the theme-switcher-icon is different for each OS, for example, the one for osx is a bit darker than the one for linux. Are you ok with having the same icon for every OS?
Flags: needinfo?(shorlander)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Abhinav, any update on this?
Flags: needinfo?(abhinav.koppula)
Flags: needinfo?(abhinav.koppula)
Attached patch PatchSplinter Review
Assignee: abhinav.koppula → jaws
Flags: needinfo?(abhinav.koppula)
Attachment #8588736 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8588736 [details] [diff] [review]
Patch

Review of attachment 8588736 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you rename "icon.png" to something more descriptive.
Attachment #8588736 - Flags: review?(gijskruitbosch+bugs) → review+
Blocks: 1073240
Version: unspecified → 35 Branch
https://hg.mozilla.org/mozilla-central/rev/f48b1b96477f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
I have successfully reproduce this bug on Firefox nightly 39.0a1 (2015-02-24)

The bug's fix is verified on latest release 40.0 (Build ID : 20150807085045)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
QA Whiteboard: [bugday-20150812]
Reproduced this bug with Nightly 39.0a1 (2015-02-24) (Build ID: 20150224030228) on Linux x64

This Bug is now verified as fixed on Latest Firefox release 40.0

Build ID: 20150807094836
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0

As it is also verified on Windows (Comment 15), Marking it as verified!
Status: RESOLVED → VERIFIED
Whiteboard: [bugday-20150812]
You need to log in before you can comment on or make changes to this bug.