1073240 - User better icon/preview for default theme

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Madhava Enros [:madhava]]

Implement the result of the design bug, bug 1059936.

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

There's been some discussion around this in bug 1074754.
We should also use the same icon in about:addons

Comment 3

[:Gijs (he/him)]

Picking this up for this iteration...

Comment 4

[Marco Mucci [:MarcoM]]

Added to IT 35.3

Comment 5

[:Gijs (he/him)]

Attachment: update Firefox's default theme icon, hide menu on non-default themes,

This is the same as what you pastebin-reviewed apart from the random whitespace (gone) and the win8 changes to use aero on vista+7, and the flat image on classic + win8. Can you doublecheck this looks good on win8?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Win8 HiDPI screenshot

Would be nice if we started using HiDPI icons.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/a70f7e0a4717

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #7)
> remote:   https://hg.mozilla.org/integration/fx-team/rev/a70f7e0a4717

Err, nope, I meant remote:   https://hg.mozilla.org/integration/fx-team/rev/f430ec9c5e3f

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f430ec9c5e3f

Comment 10

[:Gijs (he/him)]

Comment on attachment 8499685 [details] [diff] [review]
update Firefox's default theme icon, hide menu on non-default themes,

Approval Request Comment
[Feature/regressing bug #]: lwt panel feature
[User impact if declined]: ugly palette icon for default theme instead of nice relief'd firefox icon
[Describe test coverage new/current, TBPL]: not for the icon...
[Risks and why]: reasonably low, mostly just image swaps, tiny amount of JS and styling. Note that we took the menu away for custom themes with this commit, which might surprise some theme authors? They could work around if they really want to, I think, by using extra CSS, but they probably shouldn't (checking in various custom themes, it, um, didn't look very good, nor work the way it should, which is expected).
[String/UUID change made/needed]: nope

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8499685 [details] [diff] [review]
update Firefox's default theme icon, hide menu on non-default themes,

Aurora+

cc Jorge in case there is any add-on related fallout.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4599ff306a71

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

At most some theme devs will need to adjust their code. Shouldn't be a problem.