Closed Bug 1073240 Opened 7 years ago Closed 7 years ago

User better icon/preview for default theme

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 35
Iteration:
35.3
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: madhava, Assigned: Gijs)

References

Details

Attachments

(2 files)

Implement the result of the design bug, bug 1059936.
Flags: qe-verify?
Flags: firefox-backlog+
Flags: qe-verify? → qe-verify-
There's been some discussion around this in bug 1074754.
We should also use the same icon in about:addons
Points: --- → 2
Picking this up for this iteration...
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Flags: needinfo?(mmucci)
OS: Mac OS X → All
Hardware: x86 → All
Added to IT 35.3
Flags: needinfo?(mmucci)
This is the same as what you pastebin-reviewed apart from the random whitespace (gone) and the win8 changes to use aero on vista+7, and the flat image on classic + win8. Can you doublecheck this looks good on win8?
Attachment #8499685 - Flags: review?(jaws)
Attached image Win8 HiDPI screenshot
Would be nice if we started using HiDPI icons.
Attachment #8499685 - Flags: review?(jaws) → review+
(In reply to :Gijs Kruitbosch from comment #7)
> remote:   https://hg.mozilla.org/integration/fx-team/rev/a70f7e0a4717

Err, nope, I meant remote:   https://hg.mozilla.org/integration/fx-team/rev/f430ec9c5e3f
https://hg.mozilla.org/mozilla-central/rev/f430ec9c5e3f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8499685 [details] [diff] [review]
update Firefox's default theme icon, hide menu on non-default themes,

Approval Request Comment
[Feature/regressing bug #]: lwt panel feature
[User impact if declined]: ugly palette icon for default theme instead of nice relief'd firefox icon
[Describe test coverage new/current, TBPL]: not for the icon...
[Risks and why]: reasonably low, mostly just image swaps, tiny amount of JS and styling. Note that we took the menu away for custom themes with this commit, which might surprise some theme authors? They could work around if they really want to, I think, by using extra CSS, but they probably shouldn't (checking in various custom themes, it, um, didn't look very good, nor work the way it should, which is expected).
[String/UUID change made/needed]: nope
Attachment #8499685 - Flags: approval-mozilla-aurora?
Comment on attachment 8499685 [details] [diff] [review]
update Firefox's default theme icon, hide menu on non-default themes,

Aurora+

cc Jorge in case there is any add-on related fallout.
Attachment #8499685 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: needinfo?(jorge)
At most some theme devs will need to adjust their code. Shouldn't be a problem.
Flags: needinfo?(jorge)
You need to log in before you can comment on or make changes to this bug.