1136567 - (CopyPasteTest) Marionette test for selection carets' positions after changing orientation of device

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jeremy Chen ([e-mail])]

Test case for Bug 1094072

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Marionette test for selection carets' positions after changing orientation of device. r=dburns (v1)

Comment 2

[Jeremy Chen ([e-mail])]

Attachment: Marionette test for selection carets' positions after changing orientation of device. r=dburns (v2)

Remove unnecessary style settings.

Comment 3

[Jeremy Chen ([e-mail])]

Comment on attachment 8569001 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v2)

When we run test on desktop browser, set_orientation will cause "Unable to set screen orientation" exception. Need to find a way to skip orientation setting while running tests on browser.

Comment 4

[Jeremy Chen ([e-mail])]

Attachment: Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)

Skip running test on browser since set_orientation only works on B2G.

Comment 5

[Jeremy Chen ([e-mail])]

Attachment: Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)

Comment 6

[David Burns :automatedtester]

Comment on attachment 8569700 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)

Review of attachment 8569700 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change


Also make sure you rebase as bug 1107336 has changed the imports in this file

::: layout/base/tests/marionette/test_selectioncarets_multiplerange.py
@@ +143,5 @@
> +        '''Bug 1094072
> +        If positions of carets are updated correctly, they should be draggable.
> +        '''
> +        # Skip running test on browser since set_orientation only works on B2G
> +        if self.marionette.execute_script('return SpecialPowers.Services.appinfo.name;') != 'B2G':

Instead of using special powers do

if not self.marionette.session_capabilities['rotatable']:

Comment 7

[Jeremy Chen ([e-mail])]

Attachment: Marionette test for selection carets' positions after changing orientation of device. r=dburns (v4, carry r+)

Rebase. Use marionette.session_capabilities instead of special powers.

Comment 8

[Jeremy Chen ([e-mail])]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3c865079ff5

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0f098500e79

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0f098500e79