(CopyPasteTest) Marionette test for selection carets' positions after changing orientation of device

RESOLVED FIXED in Firefox 39

Status

()

Core
Selection
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla39
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Assignee: nobody → jeremychen
Created attachment 8568997 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v1)
Attachment #8568997 - Flags: review?(dburns)
Created attachment 8569001 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v2)

Remove unnecessary style settings.
Attachment #8568997 - Attachment is obsolete: true
Attachment #8569001 - Flags: review?(dburns)
Comment on attachment 8569001 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v2)

When we run test on desktop browser, set_orientation will cause "Unable to set screen orientation" exception. Need to find a way to skip orientation setting while running tests on browser.
Attachment #8569001 - Flags: review?(dburns)
Created attachment 8569696 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)

Skip running test on browser since set_orientation only works on B2G.
Attachment #8569001 - Attachment is obsolete: true
Created attachment 8569700 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)
Attachment #8569696 - Attachment is obsolete: true
Comment on attachment 8569700 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v3)

Review of attachment 8569700 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change


Also make sure you rebase as bug 1107336 has changed the imports in this file

::: layout/base/tests/marionette/test_selectioncarets_multiplerange.py
@@ +143,5 @@
> +        '''Bug 1094072
> +        If positions of carets are updated correctly, they should be draggable.
> +        '''
> +        # Skip running test on browser since set_orientation only works on B2G
> +        if self.marionette.execute_script('return SpecialPowers.Services.appinfo.name;') != 'B2G':

Instead of using special powers do

if not self.marionette.session_capabilities['rotatable']:
Attachment #8569700 - Flags: review?(dburns) → review+
Created attachment 8571174 [details] [diff] [review]
Marionette test for selection carets' positions after changing orientation of device. r=dburns (v4, carry r+)

Rebase. Use marionette.session_capabilities instead of special powers.
Attachment #8569700 - Attachment is obsolete: true
Attachment #8571174 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d0f098500e79
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.