1094072 - [Text selection] Selection carets does not update its position after devices is changing to landscape mode

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: 2014-11-05-02-30-19.png

Steps to reproduce:
1. Open UI tests app
2. Choose API at the bottom
3. Choose Copy Paste
4. Long press to select a word
5. Rotate the device to landscape mode

Result:
The position of selection carets does not update. See the attached 2014-11-05-02-30-19.png

Expected:
The position of selection carets should be correct.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Update selection carets after reflow. r=roc (v1)

Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.


Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2f494ed38bbd

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Update selection carets after reflow. r=roc (v2, carry r+)

Rebase and delete an superfluous blank line in the constructor.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3395652ef883

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3395652ef883

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3395652ef883