[Text selection] Selection carets does not update its position after devices is changing to landscape mode

RESOLVED FIXED in mozilla36

Status

()

Core
Layout
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

unspecified
mozilla36
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8517268 [details]
2014-11-05-02-30-19.png

Steps to reproduce:
1. Open UI tests app
2. Choose API at the bottom
3. Choose Copy Paste
4. Long press to select a word
5. Rotate the device to landscape mode

Result:
The position of selection carets does not update. See the attached 2014-11-05-02-30-19.png

Expected:
The position of selection carets should be correct.
(Assignee)

Comment 1

4 years ago
Created attachment 8517274 [details] [diff] [review]
Update selection carets after reflow. r=roc (v1)

Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.


Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2f494ed38bbd
Attachment #8517274 - Flags: review?(roc)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

4 years ago
Created attachment 8517914 [details] [diff] [review]
Update selection carets after reflow. r=roc (v2, carry r+)

Rebase and delete an superfluous blank line in the constructor.
Attachment #8517274 - Attachment is obsolete: true
Attachment #8517914 - Flags: review+
(Assignee)

Updated

4 years ago
Blocks: 1094607
https://hg.mozilla.org/mozilla-central/rev/3395652ef883
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.