Closed
Bug 1136618
Opened 9 years ago
Closed 9 years ago
[Stingray] expose isVisible and focus API for trusted ui
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
1. isVisible API: Determine whether this UI is visible or not, and return z-index. 2. focus API: Focus the default elementin this UI.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → im
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Luke and Sung, Please review this patch. Since it is the first one, I prefer to be reviewed by two reviewers.
Attachment #8569634 -
Flags: review?(suchiu)
Attachment #8569634 -
Flags: review?(luke)
Comment 3•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Probably wrong Luke.
Attachment #8569634 -
Flags: review?(luke)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Luke, please review this. Thanks.
Attachment #8569634 -
Flags: review?(lchang)
Comment 6•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Since 0 is consider not true, we have to change equlity conditions using isVisible function to this.isVisible() === false instead of !this.isVisible()
Attachment #8569634 -
Flags: review?(suchiu)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Thanks for the finding. I had updated the patch. Please review it again. Thanks.
Attachment #8569634 -
Flags: review?(suchiu)
Comment 8•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Looks good!!
Attachment #8569634 -
Flags: review?(suchiu) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8569634 [details] [review] [gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master Nice work. Thanks.
Attachment #8569634 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 10•9 years ago
|
||
merged to master: https://github.com/mozilla-b2g/gaia/commit/52e12d99ed1533aaa53e3bfb82e94c6b46ca5bab gaia try is all green: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=26f6fbcb095d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•