Closed Bug 1136618 Opened 9 years ago Closed 9 years ago

[Stingray] expose isVisible and focus API for trusted ui

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

Attachments

(1 file)

1. isVisible API: Determine whether this UI is visible or not, and return z-index.
2. focus API: Focus the default elementin this UI.
Assignee: nobody → im
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Luke and Sung,

Please review this patch. Since it is the first one, I prefer to be reviewed by two reviewers.
Attachment #8569634 - Flags: review?(suchiu)
Attachment #8569634 - Flags: review?(luke)
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Probably wrong Luke.
Attachment #8569634 - Flags: review?(luke)
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Luke, please review this. Thanks.
Attachment #8569634 - Flags: review?(lchang)
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Since 0 is consider not true, we have to change equlity conditions using isVisible function to this.isVisible() === false instead of !this.isVisible()
Attachment #8569634 - Flags: review?(suchiu)
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Thanks for the finding. I had updated the patch. Please review it again. Thanks.
Attachment #8569634 - Flags: review?(suchiu)
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Looks good!!
Attachment #8569634 - Flags: review?(suchiu) → review+
Comment on attachment 8569634 [details] [review]
[gaia] huchengtw-moz:bug-1136618-focus-api-trusted-ui > mozilla-b2g:master

Nice work. Thanks.
Attachment #8569634 - Flags: review?(lchang) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: