1136590 - [Stingray] focus fallback algorithm

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The fallback algorithm is:
Once a mozbrowserbeforekeydown captured, we should run the following:
1. check if the target element is invisible, body or html. If yes, run fallback.
2. list all visible system UIs (iframes and overlays)
3. sort all visible system UIs by z-index
4. focus system UI if we have system UI
5. focus appWindowManager.getActiveApp().getTopMostWindow()

The definition of element which is visible is that all of its ancestors should be visible.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1136590-focus-fallback-algorithm > mozilla-b2g:master

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8571724 [details] [review]
[gaia] huchengtw-moz:bug-1136590-focus-fallback-algorithm > mozilla-b2g:master

Hi Rex and Sung,

Please review this patch. It contains a focus manager class who handles the focus lost issue and helps other modules to focus back to top most UI.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8571724 [details] [review]
[gaia] huchengtw-moz:bug-1136590-focus-fallback-algorithm > mozilla-b2g:master

r=me

per our discussion, please add some comment that we suppose an element should be 'hidden' if one of its parent is hidden.

Comment 4

[Sung Chiu[:sungchiu]]

Comment on attachment 8571724 [details] [review]
[gaia] huchengtw-moz:bug-1136590-focus-fallback-algorithm > mozilla-b2g:master

It's good to me!

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8571724 [details] [review]
[gaia] huchengtw-moz:bug-1136590-focus-fallback-algorithm > mozilla-b2g:master

Thanks guys. Since I got two r+, I removed the review flag of Luke Chang.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/8d8d1821d6d096b33b4c814754a9f199b7b89cfd

gaia try is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=eb325138483e