Closed Bug 1136664 Opened 5 years ago Closed 5 years ago
[Call log] Phone type is not set back to "unknown" if you delete a contact
46 bytes, text/x-github-pull-request
|Details | Review|
2.38 KB, patch
|Details | Diff | Splinter Review|
STR 1. Make a phone call to an unknown phone number 2. In the call log, create a new contact from this unknown phone number => See the change in the call log 3. In the contact tab/app, delete this newly created 4. Go back to the call log Actual results You only see the phone number, without "Unknown" subtext displayed. Tested against * 2.1 => No repro * 2.2 => Repro * master before bug 1112577 landed => Repro * today's master => Repro Additional info Initially filed under bug 1136646  Build ID 20150220001208 Gaia Revision 373df4bec2c20228f45be0b24111252171f925e9 Gaia Date 2015-02-19 13:52:34 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/10c100cba54d Gecko Version 34.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20141120.194707 Firmware Date Thu Nov 20 19:47:17 EST 2014 Bootloader L1TC00011880  Build ID 20150225002505 Gaia Revision ca64f2fe145909f31af266b1730874051ba76c78 Gaia Date 2015-02-24 22:06:53 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.041814 Firmware Date Wed Feb 25 04:18:25 EST 2015 Bootloader L1TC000118D0  Build ID 20150225010244 Gaia Revision f6bfd854fe4746f21bc006eac145365e85f98808 Gaia Date 2015-02-24 21:10:44 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/0a8b3b67715a Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150225.043702 Firmware Date Wed Feb 25 04:37:14 EST 2015 Bootloader L1TC000118D0
[Blocking Requested - why for this release]: Regression which occurred in 2.2.
blocking-b2g: --- → 2.2?
Seeing no activity for a few days so just a soft reminder. Maybe we'll need someone to take look into this blocker.
Assignee: nobody → thills
Whiteboard: [planned-sprint c=?]
Target Milestone: --- → 2.2 S8 (20mar)
Assignee: thills → drs.bugzilla
Whiteboard: [planned-sprint c=?] → [planned-sprint c=3]
Hi Doug, The change looks fine and the it tested out fine for me as well. Do you mind running the unit tests on your side because I'm getting an error that I don't think is related to your change at all, but I just want to verify before we move more changes forward in this area. I'm seeing: TypeError: window.performance.mark is not a function coming from call_log_test.js:115 I want to see if it's just something I'm seeing or if we need a follow up to fix this. Thanks, -tamara
Comment on attachment 8575385 [details] [diff] [review] Set phone type in call log back to "Unknown" when a contact is deleted. Hi Doug, Looks good. I tested out also and resolved the unit test problem (on my env). Thanks, -tamara
Attachment #8575385 - Flags: review?(thills) → review+
Please request Gaia v2.2 on this when you get a chance.
Comment on attachment 8575385 [details] [diff] [review] Set phone type in call log back to "Unknown" when a contact is deleted. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Unknown [User impact] if declined: Phone number type will not show "Unknown" when a contact is deleted. [Testing completed]: Tamara and I tested this. It has been sitting on master for a while. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: None.
Attachment #8575385 - Flags: approval-gaia-v2.2?
Attachment #8575385 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds. Actual Results: The phone number type is reverted to unknown when the contact is deleted. Environmental Variables: Device: Flame 3.0 BuildID: 20150323010204 Gaia: 9b6f3024e4d0e62dd057231f4b14abe1782932ab Gecko: e730012260a4 Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Environmental Variables: Device: Flame 2.2 BuildID: 20150323002504 Gaia: 7f367fc98ffdd183f21d2cdfe20556ab877ece34 Gecko: 3ea0eaeda353 Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429 Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
You need to log in before you can comment on or make changes to this bug.