1136714 - TelemetryEnvironment reports one GMPlugin with "null" version on Android XPCSHELL tests

Status: RESOLVED DUPLICATE of bug 1133310

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Alessio Placitelli [:Dexter]]

|TelemetryEnvironment._getActiveGMPlugins| plugin data collection, introduced in bug 1122050, reports a GMPlugin with strange data during Android XPCSHELL tests.

Even though plugin.isValid is true, plugin.version is null.

This is a dump of the gathered info: {"version":null,"userDisabled":false,"applyBackgroundUpdates":1}

Comment 1

[Georg Fritzsche [:gfritzsche]]

Stephen, do the changes to GMPProvider possibly break on Android?

Comment 2

[Stephen A Pohl [:spohl]]

I don't know. What's the plugin.id for the failing GMPlugin? What's the best way for me to test this myself? Also, where does the plugin.isValid check occur? I don't see this in |TelemetryEnvironment._getActiveGMPlugins|...

Comment 3

[Alessio Placitelli [:Dexter]]

Sorry for the late answer, :spohl. I just used plugin.isValid in a test, it did not make it to m-c as it wasn't helping with this problem.

I've attached a small patch to help you reproduce the problem. This is the output I'm getting from "test_TelemetryEnvironment.js" in the Android emulator:

**** DEBUG: GMP id gmp-gmpopenh264,  version null,  userDisabled false,  applyBackgroundUpdates 1

Please let me know if there's anything else I can do to help you!

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: reproduces the issue

Comment 5

[Stephen A Pohl [:spohl]]

Comment on attachment 8571245 [details] [diff] [review]
reproduces the issue

Review of attachment 8571245 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ +806,5 @@
>  
>      let activeGMPlugins = {};
>      for (let plugin of allPlugins) {
>        // Only get GM Plugin info.
> +      if (!plugin.isGMPlugin && !plugin.isValid) {

Shouldn't this be ||, rather than &&? plugin.isValid should never be true when plugin.version is null.

Comment 6

[Alessio Placitelli [:Dexter]]

Gosh, thanks for taking time looking into this. I probably looked at the code too many times and I didn't catch that.

Comment 7

[Stephen A Pohl [:spohl]]

No worries! Please do let me know if there's still something that doesn't seem right.

Comment 8

[Georg Fritzsche [:gfritzsche]]

This sounds like the same issue as in bug 1133310, comment 1.